Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] - Upgrading with deprecated test network selected #6269

Merged
merged 2 commits into from
May 1, 2023
Merged

[FIX] - Upgrading with deprecated test network selected #6269

merged 2 commits into from
May 1, 2023

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Apr 26, 2023 •
edited by chrisleewilcox
Loading

Description
If the users were on deprecated test networks ('rinkeby', 'ropsten', 'kovan'), we added a migration to fallback to goerli since we do not support that test networks anymore.

Screenshots/Recordings
https://recordit.co/C7kpXoVVhf

Issue

Progresses #https://github.com/MetaMask/mobile-planning/issues/908

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@tommasini tommasini requested a review from a team as a code owner April 26, 2023 00:06
@tommasini tommasini added the release-6.5.0 Issue or pull request that will be included in release 6.5.0 label Apr 26, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added team-mobile-client needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 26, 2023
Cal-L
Cal-L approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tommasini tommasini added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 26, 2023
@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 28, 2023
@chrisleewilcox chrisleewilcox merged commit 2192fc6 into release/6.5.0 May 1, 2023
@chrisleewilcox chrisleewilcox deleted the fix/908-deprecate-test-networks branch May 1, 2023 17:02
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2023
@chrisleewilcox chrisleewilcox added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-6.5.0 Issue or pull request that will be included in release 6.5.0 team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tommasini @Cal-L @chrisleewilcox @gauthierpetetin