Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added strings to be translated for feature #6230 #6308

Merged
merged 1 commit into from
May 2, 2023
Merged

feat: added strings to be translated for feature #6230 #6308

merged 1 commit into from
May 2, 2023

Conversation

sethkfman
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Strings requiring translation for feature referenced in ticket.

Screenshots/Recordings

NA

Issue

Progresses #6230

Checklist

  • [NA] There is a related GitHub issue
  • [NA] Tests are included if applicable
  • [NA] Any added code is fully documented

@sethkfman sethkfman requested a review from a team as a code owner May 1, 2023 15:19
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

nikoferro
nikoferro approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@nikoferro nikoferro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-6.6.0 Issue or pull request that will be included in release 6.6.0 labels May 2, 2023
Cal-L
Cal-L approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels May 2, 2023
@Cal-L Cal-L merged commit 55dc676 into main May 2, 2023
@Cal-L Cal-L deleted the translation/swaps-token-detail branch May 2, 2023 20:09
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nikoferro nikoferro nikoferro approved these changes

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-6.6.0 Issue or pull request that will be included in release 6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sethkfman @nikoferro @Cal-L