Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDeps: Remove concat-cli #6315

Merged
merged 2 commits into from
May 3, 2023
Merged

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 2, 2023

Description

Doesn't seem to ever have been useful.
Introduced in 69381f0

Prefer cat.

Doesn't seem to ever have been useful.
Introduced in 69381f0

Prefer `cat`.
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat marked this pull request as ready for review May 2, 2023 23:43
@legobeat legobeat requested a review from a team as a code owner May 2, 2023 23:43
@legobeat legobeat added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 2, 2023
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Critical CVE ✅ 0 issues
CVE ✅ 0 issues
Mild CVE ✅ 0 issues
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
No bug tracker ✅ 0 issues
No contributors or author data ✅ 0 issues
No README ✅ 0 issues
Deprecated ✅ 0 issues
Unmaintained ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
AI detected security risk ✅ 0 issues
AI warning ✅ 0 issues

📊 Modified Dependency Overview:

🚮 Removed packages: concat-cli@4.0.0

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can't find any references to this package

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added release-6.6.0 Issue or pull request that will be included in release 6.6.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels May 3, 2023
@sethkfman sethkfman merged commit 9167a68 into MetaMask:main May 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2023
@legobeat legobeat deleted the devDeps-drop-concat-cli branch May 3, 2023 23:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-6.6.0 Issue or pull request that will be included in release 6.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants