Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create a performance E2E test for warm starts #6865

Merged
merged 6 commits into from
Jul 28, 2023
Merged

feat: Create a performance E2E test for warm starts #6865

merged 6 commits into from
Jul 28, 2023

Conversation

SamuelSalas
Copy link
Member

Description
Feature test case created to test the warm start of the app from multiple devices. It sends the app to the background for 30 seconds so the Login screen appears.

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@SamuelSalas SamuelSalas requested a review from a team as a code owner July 22, 2023 00:29
@SamuelSalas SamuelSalas changed the title Create a performance E2E test for warm starts feat: Create a performance E2E test for warm starts Jul 22, 2023
Andepande
Andepande previously approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cortisiko
cortisiko requested changes Jul 24, 2023
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, just left some feedback on your feature file.

wdio/features/Performance/WarmStartPerformance.feature Outdated Show resolved Hide resolved
wdio/features/Performance/WarmStartPerformance.feature Show resolved Hide resolved
wdio/features/Performance/WarmStartPerformance.feature Outdated Show resolved Hide resolved
@cortisiko
Copy link
Member

Lets also go ahead and change the name of https://github.com/MetaMask/metamask-mobile/blob/feature/700-performance-test-warm-starts/wdio/features/Performance/AppLaunchTime.feature to ColdStartLaunchTimes.feature

@SamuelSalas
Move single step from warm start performance to app launch times. Add…
c7d281f 
…ed foreground step to the Warm Start Performance feature
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

cortisiko
cortisiko approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me sam! great work!

@cortisiko cortisiko merged commit b7fb3f5 into main Jul 28, 2023
@cortisiko cortisiko deleted the feature/700-performance-test-warm-starts branch July 28, 2023 02:21
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
@metamaskbot metamaskbot added the release-7.5.0 Issue or pull request that will be included in release 7.5.0 label Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@Andepande Andepande Andepande left review comments

@chrisleewilcox chrisleewilcox Awaiting requested review from chrisleewilcox

Assignees
No one assigned
Labels
release-7.5.0 Issue or pull request that will be included in release 7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SamuelSalas @cortisiko @Andepande @metamaskbot