Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added README to Avatar #6895

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Added README to Avatar #6895

merged 4 commits into from
Aug 2, 2023

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Jul 25, 2023 •
edited by georgewrmarshall
Loading

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
Added README to Avatar

Screenshots/Recordings
Screenshot 2023-07-24 at 11 54 11 PM

Issue

fixes #6680

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Jul 25, 2023
@brianacnguyen brianacnguyen self-assigned this Jul 25, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner July 25, 2023 06:55
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

georgewrmarshall
georgewrmarshall requested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left some small suggestions

app/component-library/components/Avatars/Avatar/README.md Outdated Show resolved Hide resolved
app/component-library/components/Avatars/Avatar/README.md Outdated Show resolved Hide resolved
app/component-library/components/Avatars/Avatar/README.md Outdated Show resolved Hide resolved
app/component-library/components/Avatars/Avatar/README.md Outdated Show resolved Hide resolved
app/component-library/components/Avatars/Avatar/README.md Outdated Show resolved Hide resolved
georgewrmarshall
georgewrmarshall approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but left a comment about README links

app/component-library/components/Avatars/Avatar/README.md Outdated Show resolved Hide resolved
leotm
leotm reviewed Jul 27, 2023
View reviewed changes
Copy link
Member

@leotm leotm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except couple 404's spotted

georgewrmarshall
georgewrmarshall requested changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like those links still need updating going to unresolve until they've been updated

georgewrmarshall
georgewrmarshall approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@brianacnguyen brianacnguyen merged commit d5fbad2 into main Aug 2, 2023
11 checks passed
@brianacnguyen brianacnguyen deleted the morph/readme-avatar branch August 2, 2023 20:41
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 2, 2023
@metamaskbot metamaskbot added the release-7.6.0 Issue or pull request that will be included in release 7.6.0 label Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leotm leotm leotm left review comments

@owencraston owencraston owencraston approved these changes

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
release-7.6.0 Issue or pull request that will be included in release 7.6.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create README for Avatar component
5 participants
@brianacnguyen @leotm @georgewrmarshall @owencraston @metamaskbot