refactor: Update core controllers (v45)

[Gudahtt]

Development & PR Process

1. Follow MetaMask Mobile Coding Standards
2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
3. Add needs-dev-review label when work is completed
4. Add needs-qa label when dev review is completed
5. Add QA Passed label when QA has signed off

Description

Update core controllers to match the v45 monorepo release. The network controller has been updated to v7, and the assets controllers have been updated to v5.1.0.

The phishing controller and message manager updates have been held back to reduce the scope of the PR. They will be updated in a later PR.

Release notes: https://github.com/MetaMask/core/releases/tag/v45.0.0

Issue

This relates to https://github.com/MetaMask/mobile-planning/issues/877

Checklist

• There is a related GitHub issue
• Tests are included if applicable
• Any added code is fully documented

[socket-security]

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@metamask/network-controller	7.0.0	None	+0	73.2 kB	metamaskbot
@metamask/assets-controllers	5.0.1...5.1.0	None	+1/-0	665 kB	metamaskbot

[Gudahtt]

This has been rebased onto #6898 .

Passing e2e test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9577199b-c426-47ea-8371-7fbed7eb4a30

[codecov-commenter]

Codecov Report

Merging #6902 (a1b4372) into update-assets-controllers-patch (61d86c2) will increase coverage by 0.01%.
The diff coverage is 31.91%.

❗ Current head a1b4372 differs from pull request most recent head 6101dc3. Consider uploading reports for the commit 6101dc3 to get more accurate results

@@                         Coverage Diff                         @@
##           update-assets-controllers-patch    #6902      +/-   ##
===================================================================
+ Coverage                            32.68%   32.69%   +0.01%     
===================================================================
  Files                                  994      996       +2     
  Lines                                26649    26652       +3     
  Branches                              2088     2084       -4     
===================================================================
+ Hits                                  8710     8714       +4     
+ Misses                               17525    17524       -1     
  Partials                               414      414              

Files Changed	Coverage Δ
app/components/UI/AddCustomToken/index.js	31.48% <0.00%> (ø)
.../UI/ApproveTransactionReview/AddNickname/index.tsx	7.01% <ø> (ø)
...proveTransactionReview/ShowBlockExplorer/index.tsx	14.28% <ø> (ø)
...ew/VerifyContractDetails/VerifyContractDetails.tsx	44.44% <0.00%> (ø)
...pp/components/UI/ApproveTransactionReview/index.js	3.96% <0.00%> (ø)
app/components/UI/DrawerView/index.js	3.72% <0.00%> (ø)
app/components/UI/NetworkModal/index.tsx	4.54% <0.00%> (ø)
app/components/UI/Ramp/Views/OrderDetails.tsx	6.25% <0.00%> (ø)
app/components/UI/Ramp/components/OrderDetails.tsx	11.29% <0.00%> (ø)
...mponents/UI/Ramp/hooks/useHandleSuccessfulOrder.ts	0.00% <0.00%> (ø)
... and 39 more

... and 19 files with indirect coverage changes

[tommasini]

Amazing, very happy to see that we are pushing forward the version with phishing controller improvements, for that controller use less memory/bandwidth

Notice here that we would need to change the addAsset of asset controller where it's used, because the structures of the arguments changed on this assets controller version from
addToken(address, symbol, decimals, image, interactingAddress)
to
addToken(address, symbol, decimals, { name, image, interactingAddress })

with this said we should change on the following places:
useAddressBalance.ts --> line 45
TokensController.addToken( contractAddress, symbol, decimals, { image, name,} );

UI/AddCustomToken.js --> line 120
TokensController.addToken(address, symbol, decimals, {name})

useHandleSuccessfullOrder.ts --> line 48
TokensController.addToken(address, symbol, decimals, {name})

SearchTokenAutocomplete --> line 110
TokensController.addToken(address, symbol, decimals, {image: iconUrl, name})

UI/Swaps --> line 531
TokensController.addToken(address, symbol, decimals,{ name})

QuotesView --> line 351
TokensController.addToken(address, symbol, decimals,{ name})

SendFlow/Confirm --> lien 527
TokensController.addToken(address, symbol, decimals, {image, name})

[Gudahtt]

Thanks @tommasini . I think those requested changes have already been made (in #6898, which this PR is based on). Let me know if there are any that were missed

[tommasini]

Sorry, totally missed that dependency! Looks good to me!

The base branch was changed.

[Gudahtt]

All blockers have been resolved, so this has been rebased onto main. Diff should be the same as before, when it was approved by @tommasini

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

[Cal-L]

code LGTM

[cortisiko]

🌮 🌮 🌮 🌮