Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused Jest preprocessor #6913

Merged
merged 1 commit into from
Jul 28, 2023
Merged

chore: remove unused Jest preprocessor #6913

merged 1 commit into from
Jul 28, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jul 26, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

The file jest.preprocessor.js has been unused since #6170.

Issue

N/A

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Gudahtt Gudahtt marked this pull request as ready for review July 26, 2023 22:44
@Gudahtt Gudahtt requested a review from a team as a code owner July 26, 2023 22:44
@Gudahtt Gudahtt force-pushed the remove-unused-jest-preprocessor branch from fc7d6e8 to edb2e1a Compare July 27, 2023 11:51
@Gudahtt Gudahtt added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 27, 2023
@Gudahtt Gudahtt force-pushed the remove-unused-jest-preprocessor branch from edb2e1a to 6d09e80 Compare July 27, 2023 15:59
@Gudahtt Gudahtt added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 27, 2023
@Gudahtt
chore: remove unused Jest preprocessor
6593860 
The file `jest.preprocessor.js` has been unused since #6170.
@Gudahtt Gudahtt force-pushed the remove-unused-jest-preprocessor branch from 6d09e80 to 6593860 Compare July 27, 2023 23:40
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sethkfman
sethkfman approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt merged commit f7ef53c into main Jul 28, 2023
@Gudahtt Gudahtt deleted the remove-unused-jest-preprocessor branch July 28, 2023 23:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 28, 2023
@metamaskbot metamaskbot added the release-7.6.0 Issue or pull request that will be included in release 7.6.0 label Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.6.0 Issue or pull request that will be included in release 7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gudahtt @sethkfman @metamaskbot