Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 7.4.0 version bump #6924

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

sethkfman
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add No QA/E2E only when dev review is completed and your PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.
  6. Apply Spot check on release build for PRs not requiring feature QA but needing non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.
  7. Add QA Passed label when QA has signed off

Description

Version bump for new RC build

Screenshots/Recordings

NA

Issue

NA

@sethkfman sethkfman requested a review from a team as a code owner July 28, 2023 18:08
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug D 13 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 67 Code Smells

37.6% 37.6% Coverage
3.8% 3.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sethkfman sethkfman merged commit e4d64e2 into release/7.4.0 Jul 28, 2023
10 of 11 checks passed
@sethkfman sethkfman deleted the chore/7.4.0-version-bump branch July 28, 2023 19:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants