Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trigger E2E from PR label #7307

Closed
wants to merge 70 commits into from
Closed

feat: trigger E2E from PR label #7307

wants to merge 70 commits into from

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Sep 22, 2023

Description

This PR enables E2E to run on every PR push that is out of the draft stage. It is an effort to reduce friction for E2E.

Manual testing steps

_1. Create a PR and push a commit message without "e2e" see bitrise step fail
_1. Create a PR and push a commit message with "e2e" see bitrise step succeed and start tests

Screenshots/Recordings

Fail

Success

Fixes #???

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman marked this pull request as ready for review September 22, 2023 21:20
@sethkfman sethkfman requested a review from a team as a code owner September 22, 2023 21:20
@sethkfman sethkfman marked this pull request as draft September 22, 2023 21:24
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3d694ae) 34.62% compared to head (1f00460) 34.62%.
Report is 2 commits behind head on main.

❗ Current head 1f00460 differs from pull request most recent head 6e468f7. Consider uploading reports for the commit 6e468f7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7307   +/-   ##
=======================================
  Coverage   34.62%   34.62%           
=======================================
  Files        1019     1019           
  Lines       27192    27192           
  Branches     2217     2217           
=======================================
  Hits         9414     9414           
  Misses      17287    17287           
  Partials      491      491           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethkfman sethkfman changed the title chore: enable E2E running on non-draft PRs chore: enable E2E on PRs when "e2e" is in commit message Sep 22, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sethkfman sethkfman marked this pull request as ready for review September 22, 2023 21:55
@sethkfman sethkfman added team-mobile-client release-7.9.0 Issue or pull request that will be included in release 7.9.0 labels Sep 22, 2023
@sethkfman sethkfman marked this pull request as draft September 22, 2023 22:04
@Cal-L Cal-L removed the Run E2E label Oct 14, 2023
@Cal-L Cal-L added the Run E2E label Oct 14, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sethkfman sethkfman added release-7.10.0 Issue or pull request that will be included in release 7.10.0 and removed release-7.9.0 Issue or pull request that will be included in release 7.9.0 labels Oct 23, 2023
@metamaskbot metamaskbot added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Oct 26, 2023
@sethkfman
Copy link
Contributor Author

Covered by another PR

@sethkfman sethkfman closed this Oct 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
@github-actions github-actions bot removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.10.0 Issue or pull request that will be included in release 7.10.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants