ci: Create github action for triggering Bitrise E2E builds based on label #7339

Cal-L · 2023-09-26T19:45:24Z

Description

This PR introduces a new workflow (check-bitrise-e2e-smoke), which applies the Run Smoke E2E label to the PR, kicks off a Bitrise build (pr_smoke_e2e_pipeline), and will post a comment to the PR containing a link to the E2E build. The workflow is triggered under 4 conditions:

Whenever the Run Smoke E2E label is added to a pull request
When a PR is opened that is not draft
When a PR goes from draft to ready for review
When a PR is reopened

Manual testing steps

Scenario: Triggered by adding the Run Smoke E2E label

If the Run Smoke E2E label exists on the PR, first remove it. Otherwise, skip to step two
Re-add the Run Smoke E2E label back to the PR
After a second or two, the Check Bitrise E2E Smoke Tests workflow will run in the CI checks
Shortly after, the Run Smoke E2E label should be automatically added to the PR
Once that workflow is complete, the github bot will post a comment that contains a link to the Bitrise E2E build

Scenario: Triggered by opening a non-draft PR

Open a non-draft PR
After a second or two, the Check Bitrise E2E Smoke Tests workflow will run in the CI checks
Shortly after, the Run Smoke E2E label should be automatically added to the PR
Once that workflow is complete, the github bot will post a comment that contains a link to the Bitrise E2E build

Scenario: Triggered by making a draft PR ready for review

Mark the draft PR as ready for review
After a second or two, the Check Bitrise E2E Smoke Tests workflow will run in the CI checks
Shortly after, the Run Smoke E2E label should be automatically added to the PR
Once that workflow is complete, the github bot will post a comment that contains a link to the Bitrise E2E build

Scenario: Triggered by reopening a non-draft PR

Reopen a non-draft PR
After a second or two, the Check Bitrise E2E Smoke Tests workflow will run in the CI checks
Shortly after, the Run Smoke E2E label should be automatically added to the PR
Once that workflow is complete, the github bot will post a comment that contains a link to the Bitrise E2E build

Screenshots/Recordings

Before

After

Video of the workflow being triggered by adding the Run E2E label.
https://github.com/MetaMask/metamask-mobile/assets/10508597/f6f503ac-1d61-4734-af12-cdfcecbeaec9

Video of the workflow being triggered by updating a draft PR to ready for review.
https://github.com/MetaMask/metamask-mobile/assets/10508597/fa9b8bf0-9317-4a26-9993-8f2f4d3d1e6f

Video of the workflow being triggered by reopening a PR.
https://github.com/MetaMask/metamask-mobile/assets/10508597/2acd05e2-3777-4e63-9f03-480f55f1a32b

Video of the workflow being triggered by opening a PR.
https://github.com/MetaMask/metamask-mobile/assets/10508597/238b3234-9a74-4b30-9893-5b5cf3591cd5

Comment that is posted once the build is started.

Related issues

Fixes #???

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2023-09-26T19:45:38Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov-commenter · 2023-09-26T20:04:26Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72f6690) 34.96% compared to head (59409c1) 34.96%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7339   +/-   ##
=======================================
  Coverage   34.96%   34.96%           
=======================================
  Files        1030     1030           
  Lines       27401    27401           
  Branches     2253     2253           
=======================================
  Hits         9580     9580           
  Misses      17311    17311           
  Partials      510      510

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This reverts commit 1acc611.

…to feature/label-triggered-e2e-test

github-actions · 2023-10-26T18:58:07Z

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ff543ee1-0323-44b5-9373-4db32d43d847

github-actions · 2023-10-26T19:06:19Z

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5d162c77-f888-45f5-b9ca-561097aa628d
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

sonarcloud · 2023-10-26T19:20:08Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

cortisiko

✅ ✅ ✅ ✅

Cal-L · 2023-10-27T16:24:51Z

.github/scripts/check-bitrise-e2e-smoke/check-e2e-smoke-trigger.ts

+        process.exit(1);
+      }
+    } catch (error) {
+      console.log(`Error occured when applying label: ${error}`);


Update this to setFailed instead

tommasini

LGTM!

Create github action for triggering Bitrise E2E builds based on label

0f72d3e

Cal-L added the needs-smoke-e2e label Sep 26, 2023

Remove -L

30699ac

Cal-L added needs-smoke-e2e and removed needs-smoke-e2e labels Sep 26, 2023

Fix string

89252de

Cal-L added needs-smoke-e2e and removed needs-smoke-e2e labels Sep 26, 2023

Cal-L added 2 commits September 26, 2023 14:51

Update format

9f0f615

Remove unrelated workflows

1acc611

Cal-L removed the needs-smoke-e2e label Sep 26, 2023

Remove PR id

571302d

Cal-L added the needs-smoke-e2e label Sep 26, 2023

Add back PR ID

a9fcef0

Cal-L added needs-smoke-e2e and removed needs-smoke-e2e labels Sep 26, 2023

Fix workflow

748323a

Cal-L added needs-smoke-e2e and removed needs-smoke-e2e labels Sep 26, 2023

Simplify Bitrise command

3202a66

Cal-L added needs-smoke-e2e and removed needs-smoke-e2e labels Sep 26, 2023

Remove extra comma

f4bd209

Cal-L added needs-smoke-e2e and removed needs-smoke-e2e labels Sep 26, 2023

Cal-L added 3 commits October 17, 2023 10:12

Revert "Remove unrelated workflows"

e54d17e

This reverts commit 1acc611.

Merge branch 'main' of https://github.com/MetaMask/metamask-mobile in…

63c33ab

…to feature/label-triggered-e2e-test

Comment out label triggered workflow

07c1e7f

Cal-L closed this Oct 26, 2023

Cal-L reopened this Oct 26, 2023

github-actions bot unlocked this conversation Oct 26, 2023

Cal-L closed this Oct 26, 2023

Cal-L reopened this Oct 26, 2023

github-actions bot locked and limited conversation to collaborators Oct 26, 2023

github-actions bot unlocked this conversation Oct 26, 2023

metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 26, 2023

Merge branch 'main' of https://github.com/MetaMask/metamask-mobile in…

fe0bb10

…to feature/label-triggered-e2e-test

metamaskbot added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 26, 2023

Cal-L added Run Smoke E2E and removed Run Smoke E2E labels Oct 26, 2023

MetaMask deleted a comment from github-actions bot Oct 26, 2023

Cal-L added 2 commits October 26, 2023 12:01

Add instructions to re-build Bitrise E2E smoke tests

34fa593

Update workflow name

59409c1

Cal-L added Run Smoke E2E and removed Run Smoke E2E labels Oct 26, 2023

cortisiko approved these changes Oct 26, 2023

View reviewed changes

Cal-L merged commit b4b3574 into main Oct 26, 2023
28 checks passed

Cal-L deleted the feature/label-triggered-e2e-test branch October 26, 2023 22:08

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 26, 2023

github-actions bot locked and limited conversation to collaborators Oct 26, 2023

metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Oct 26, 2023

Cal-L commented Oct 27, 2023

View reviewed changes

tommasini reviewed Oct 27, 2023

View reviewed changes

gauthierpetetin added the team-mobile-platform label Feb 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: Create github action for triggering Bitrise E2E builds based on label #7339

ci: Create github action for triggering Bitrise E2E builds based on label #7339

Cal-L commented Sep 26, 2023 •

edited

Loading

github-actions bot commented Sep 26, 2023

codecov-commenter commented Sep 26, 2023 •

edited

Loading

github-actions bot commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

sonarcloud bot commented Oct 26, 2023

cortisiko left a comment

Cal-L Oct 27, 2023

tommasini left a comment

ci: Create github action for triggering Bitrise E2E builds based on label #7339

ci: Create github action for triggering Bitrise E2E builds based on label #7339

Conversation

Cal-L commented Sep 26, 2023 • edited Loading

Description

Manual testing steps

Screenshots/Recordings

Before

After

Related issues

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 26, 2023

codecov-commenter commented Sep 26, 2023 • edited Loading

Codecov Report

github-actions bot commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

sonarcloud bot commented Oct 26, 2023

cortisiko left a comment

Choose a reason for hiding this comment

Cal-L Oct 27, 2023

Choose a reason for hiding this comment

tommasini left a comment

Choose a reason for hiding this comment

Cal-L commented Sep 26, 2023 •

edited

Loading

codecov-commenter commented Sep 26, 2023 •

edited

Loading