Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add RN patch for boost (#8221) #8222

Merged
merged 2 commits into from
Jan 8, 2024

Commits on Jan 8, 2024

  1. fix: add RN patch for boost (#8221)

    ## **Description**
    * RN was failing because of a down 3rd parties dependencies called
    [boost](https://www.boost.org/) which is a C++ utility library.
    
    * RN suggested [this
    fix](facebook/react-native#42180)
    * But another file in react-native [needed to be updated for
    Android](software-mansion/react-native-reanimated#5542)
    as well
    
    _The boost library URL needed to be updated in 2 places_
    **This PR incorporates both updates of the boost library download URL
    into the patch of react-native**
    
    
    Smoke tests passing:
    
    https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/675c4c9f-22b4-461b-803c-04d3db6dd595
    
    <!--
    Write a short description of the changes included in this pull request,
    also include relevant motivation and context. Have in mind the following
    questions:
    1. What is the reason for the change?
    2. What is the improvement/solution?
    -->
    
    ## **Related issues**
    
    Fixes:
    
    ## **Manual testing steps**
    
    1. Go to this page...
    2.
    3.
    
    ## **Screenshots/Recordings**
    
    <!-- If applicable, add screenshots and/or recordings to visualize the
    before and after of your change. -->
    
    ### **Before**
    
    <!-- [screenshots/recordings] -->
    
    ### **After**
    
    <!-- [screenshots/recordings] -->
    
    ## **Pre-merge author checklist**
    
    - [ ] I’ve followed [MetaMask Coding
    Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
    - [ ] I've clearly explained what problem this PR is solving and how it
    is solved.
    - [ ] I've linked related issues
    - [ ] I've included manual testing steps
    - [ ] I've included screenshots/recordings if applicable
    - [ ] I’ve included tests if applicable
    - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [ ] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    - [ ] I’ve properly set the pull request status:
      - [ ] In case it's not yet "ready for review", I've set it to "draft".
    - [ ] In case it's "ready for review", I've changed it from "draft" to
    "non-draft".
    
    ## **Pre-merge reviewer checklist**
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    frankvonhoven committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    92efcbe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    da50afe View commit details
    Browse the repository at this point in the history