-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve native balance fetch logic on the UX #8556
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
bb9a9fb
to
f2a1df0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8556 +/- ##
=======================================
Coverage 41.05% 41.05%
=======================================
Files 1247 1247
Lines 30362 30371 +9
Branches 2964 2965 +1
=======================================
+ Hits 12464 12468 +4
- Misses 17153 17158 +5
Partials 745 745 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8aa420f9-0e8d-4103-b819-bf2c942ca6ed |
Error on regression tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://app.bitrise.io/build/10e18cd4-22e2-4688-b017-44cb87f8716c to address test failure.
fixed |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a1cc2f19-14a4-4c12-9e30-0d50b8d10ac3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment
app/components/Views/Settings/SecuritySettings/Sections/RevealPrivateKey/RevealPrivateKey.tsx
Outdated
Show resolved
Hide resolved
eaeed3e
to
36e07f0
Compare
27e2649
to
65e9c0b
Compare
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5d63e9b4-b18a-4401-a895-89dce4049157 |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Problem: When we change network or account, the native balance of the ERC-20 tokens is not reset. It shows a wrong value for a couple seconds and then updates.
We should reset the state and show a skeleton text instead of a wrong value.
PR already Merged on core
Related issues
Fixes: #6101
Manual testing steps
Screenshots/Recordings
Before
before.mov
After
after.mov
Pre-merge author checklist
Pre-merge reviewer checklist