Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Accounts controller integration #8759

Merged
merged 47 commits into from
Mar 21, 2024
Merged

feat: Accounts controller integration #8759

merged 47 commits into from
Mar 21, 2024

Commits on Mar 20, 2024

  1. install accounts controller

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    ecd6d6f View commit details
    Browse the repository at this point in the history

  2. Accounts controller actions/events

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    2a9f555 View commit details
    Browse the repository at this point in the history

  3. tokensController

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    c023b98 View commit details
    Browse the repository at this point in the history

  4. keyring controller

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    aaf56e4 View commit details
    Browse the repository at this point in the history

  5. PermissionController and specification.js

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    e97ba02 View commit details
    Browse the repository at this point in the history

  6. captureKeyringTypesWithMissingIdentities

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    6ea67a8 View commit details
    Browse the repository at this point in the history

  7. AccountTrackerController as a variable

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    3518a8d View commit details
    Browse the repository at this point in the history

  8. fix types in jsdoc for specifications.js

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    bf85cb7 View commit details
    Browse the repository at this point in the history

  9. pass prev state to subscription

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    8793187 View commit details
    Browse the repository at this point in the history

  10. add accounts controller to engine service

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    214db2a View commit details
    Browse the repository at this point in the history

  11. dedupe

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    892bce9 View commit details
    Browse the repository at this point in the history

  12. fix Engine.test.js

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    6797050 View commit details
    Browse the repository at this point in the history

  13. fix specifications test

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    2cf3f01 View commit details
    Browse the repository at this point in the history

  14. improve permission specification test

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    87fe49a View commit details
    Browse the repository at this point in the history

  15. migrate all selectedAddress methods

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    1b28a7f View commit details
    Browse the repository at this point in the history

  16. install after rebase

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    d429b99 View commit details
    Browse the repository at this point in the history

  17. reset scripts/ios/bundle-js-and-sentry-upload.sh

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    aa6dbb5 View commit details
    Browse the repository at this point in the history

  18. decouple Accounts controller from snaps controller

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    6c23b9d View commit details
    Browse the repository at this point in the history

  19. migration

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    3e3273b View commit details
    Browse the repository at this point in the history

  20. update lavamoat configuration

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    dd9d66e View commit details
    Browse the repository at this point in the history

  21. fix all type errors

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    56451e0 View commit details
    Browse the repository at this point in the history

  22. fix lint and use ethereumjs-util as extension

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    d20b9b6 View commit details
    Browse the repository at this point in the history

  23. activate migration and log state

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    465891d View commit details
    Browse the repository at this point in the history

  24. add accounts controller to context

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    3f876f1 View commit details
    Browse the repository at this point in the history

  25. downgrade ethereumjs-util 7.0.1 to resolve BN.js issues

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    ce8ab91 View commit details
    Browse the repository at this point in the history

  26. add back old eslint ignore

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    95a6402 View commit details
    Browse the repository at this point in the history

  27. wrap isValidAddress in a try catch

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    22cd0e2 View commit details
    Browse the repository at this point in the history

  28. use aes for sha256

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    2d55e8b View commit details
    Browse the repository at this point in the history

  29. fix shasum

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    f11b7a2 View commit details
    Browse the repository at this point in the history

  30. fix test

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    534b042 View commit details
    Browse the repository at this point in the history

  31. cleanup

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    d5a6855 View commit details
    Browse the repository at this point in the history

  32. dedupe

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    86b7d11 View commit details
    Browse the repository at this point in the history

  33. cleanup

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    d2ae115 View commit details
    Browse the repository at this point in the history

  34. new method to setSelectedAccount

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    3412e88 View commit details
    Browse the repository at this point in the history

  35. fix tests

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    9206e07 View commit details
    Browse the repository at this point in the history

  36. address Charly's comments

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    78f5057 View commit details
    Browse the repository at this point in the history

  37. address Monte's feedback 

    - use accounts controller as selected address source of truth
- do not use all ethmethods for permissions tests
    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    924e23a View commit details
    Browse the repository at this point in the history

  38. compute lowercase value outside of loops

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    8966b5e View commit details
    Browse the repository at this point in the history

  39. remove logs

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    1f4d828 View commit details
    Browse the repository at this point in the history

  40. correct migration numbers in logs

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    15664a0 View commit details
    Browse the repository at this point in the history

  41. handle case in migration where selectedAddress is not a string

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    8aadfa3 View commit details
    Browse the repository at this point in the history

  42. fix tests and get firstAddress from preferences controller

    @owencraston
    owencraston committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    2384808 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. manually state permitted methods

    @owencraston
    owencraston committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    ddb5d3d View commit details
    Browse the repository at this point in the history

  2. test empty indentities

    @owencraston
    owencraston committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    daadd0c View commit details
    Browse the repository at this point in the history

  3. add logs for edge cases in migration

    @owencraston
    owencraston committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    35df1a1 View commit details
    Browse the repository at this point in the history

  4. remove 4337 methods

    @owencraston
    owencraston committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    9db203a View commit details
    Browse the repository at this point in the history

  5. remove code fenced 'SnapController:stateChange' event and removed patch

    @owencraston
    owencraston committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    032b30c View commit details
    Browse the repository at this point in the history