Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix url bug display #8877

Merged
merged 1 commit into from
Mar 8, 2024
Merged

fix: fix url bug display #8877

merged 1 commit into from
Mar 8, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Mar 7, 2024

Description

There is a bug with the RPC url not being displayed correctly when trying to add a network via a dapp. This raises a security concern because the user can potentially add a malicious network if a network RPC URL is not shown.

Furthermore, the height of the network added sheet extends further than that of prod.

Related issues

Fixes: #1586

Manual testing steps

  1. Given I am on the browser view
  2. And I connect my wallet to chainlist.wtf
  3. When I add "Avalanche"
  4. Then the add network sheet is displayed
  5. But the RPC URL is not displayed correctly

Screenshots/Recordings

Before

before-bug

After

fix-bug

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested a review from a team as a code owner March 7, 2024 14:59
Copy link
Contributor

github-actions bot commented Mar 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added team-assets type-bug Something isn't working team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing labels Mar 7, 2024
@salimtb salimtb marked this pull request as draft March 7, 2024 15:15
@salimtb salimtb force-pushed the fix-url-display-bug branch 4 times, most recently from 63544cc to e850b37 Compare March 7, 2024 15:42
@salimtb salimtb marked this pull request as ready for review March 7, 2024 16:20
@github-actions github-actions bot added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 7, 2024
Copy link
Contributor

github-actions bot commented Mar 7, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 344db4b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/988e2e71-639c-40fe-90de-5a51b0dca97f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Mar 7, 2024

@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 7, 2024
@sethkfman sethkfman added the regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead label Mar 8, 2024
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 8, 2024
@cortisiko
Copy link
Member

Regression and Smoke tests passed on this PR

@salimtb salimtb merged commit f5c63e9 into main Mar 8, 2024
38 of 41 checks passed
@salimtb salimtb deleted the fix-url-display-bug branch March 8, 2024 18:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
@metamaskbot metamaskbot added release-7.19.0 Issue or pull request that will be included in release 7.19.0 release-7.18.0 Issue or pull request that will be included in release 7.18.0 and removed release-7.19.0 Issue or pull request that will be included in release 7.19.0 labels Mar 8, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-7.18.0 on PR. Adding release label release-7.18.0 on PR and removing other release labels(release-7.19.0), as PR was cherry-picked in branch 7.18.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-7.18.0 Issue or pull request that will be included in release 7.18.0 Run Smoke E2E Triggers smoke e2e on Bitrise Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-assets team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants