-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix url bug display #8877
fix: fix url bug display #8877
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
63544cc
to
e850b37
Compare
e850b37
to
344db4b
Compare
Bitrise✅✅✅ Commit hash: 344db4b Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Regression and Smoke tests passed on this PR |
Missing release label release-7.18.0 on PR. Adding release label release-7.18.0 on PR and removing other release labels(release-7.19.0), as PR was cherry-picked in branch 7.18.0. |
Description
There is a bug with the RPC url not being displayed correctly when trying to add a network via a dapp. This raises a security concern because the user can potentially add a malicious network if a network RPC URL is not shown.
Furthermore, the height of the network added sheet extends further than that of prod.
Related issues
Fixes: #1586
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist