Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): upgrade eth-json-rpc-filters, eth-json-rpc-engine #9274

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

fix(deps): upgrade eth-json-rpc-filters, eth-json-rpc-engine #9274

wants to merge 10 commits into from
+115 −72

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Apr 17, 2024 •
edited
Loading

Description

The runtime dependencies eth-json-rpc-filters and json-rpc-engine are both deprecated. This replaces them with their successors @metamask/eth-json-rpc-filters and @metamask/json-rpc-engine, respectively.

Related issues

Manual testing steps

n/a

Screenshots/Recordings

Before

n/a

After

n/a

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions

This comment was marked as off-topic.

Sign in to view
@legobeat legobeat changed the title Deps eth json rpc filters fix(deps): upgrade eth-json-rpc-filters, eth-json-rpc-engine Apr 17, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Apr 17, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Apr 17, 2024
@legobeat
Copy link
Contributor Author 

@SocketSecurity ignore npm/@metamask/eth-json-rpc-infura@9.1.0

@legobeat legobeat mentioned this pull request Apr 17, 2024
Closed
7 tasks
@socket-security Socket Security
Copy link

socket-security bot commented Apr 17, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/eth-json-rpc-filters@7.0.0 None 0 24.6 kB lgbot

🚮 Removed packages: npm/eth-json-rpc-filters@4.2.2

View full report↗︎

@legobeat legobeat force-pushed the deps-eth-json-rpc-filters branch 4 times, most recently from 53c8a35 to 69be175 Compare April 18, 2024 21:09
@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 18, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@legobeat legobeat force-pushed the deps-eth-json-rpc-filters branch 3 times, most recently from a443778 to 9b7463f Compare April 18, 2024 22:03
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 18, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 19, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 19, 2024
@legobeat
Copy link
Contributor Author

The failing Check for js or jsx file being added rule seems to FP on changed files and interpreting them as added.

@legobeat

This comment was marked as resolved.

Sign in to view
This was referenced Jun 11, 2024
Closed
Closed
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 8920824
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53b4eec6-1e48-4c84-8fd7-aaa5dcf16513

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
57.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8920824
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53b4eec6-1e48-4c84-8fd7-aaa5dcf16513

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

3 similar comments
@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8920824
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53b4eec6-1e48-4c84-8fd7-aaa5dcf16513

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8920824
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53b4eec6-1e48-4c84-8fd7-aaa5dcf16513

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@metamaskbot
Copy link
Collaborator

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8920824
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53b4eec6-1e48-4c84-8fd7-aaa5dcf16513

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Mrtenz Mrtenz removed their request for review July 4, 2024 09:12
@legobeat legobeat mentioned this pull request Sep 20, 2024
Closed
7 tasks
@legobeat legobeat mentioned this pull request Oct 25, 2024
Merged
7 tasks
@legobeat
Copy link
Contributor Author

The eth-json-rpc-filters upgrade has been broken out into:

github-merge-queue bot pushed a commit that referenced this pull request Oct 29, 2024
@legobeat
chore: eth-json-rpc-filters@^6.0.1 -> @metamask/eth-json-rpc-filters@…
c773d7a 
…^8.0.0 (#12024)

## **Description**

Replace deprecated `eth-json-rpc-filters` with
`@metamask/eth-json-rpc-filters`.

## **Related issues**

- Part of: #12047
- Broken out from: #9274, #11952
- Follow-up to: #11980


## **Manual testing steps**


## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire Awaiting requested review from mcmire

@FrederikBolding FrederikBolding Awaiting requested review from FrederikBolding

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file DO-NOT-MERGE Pull requests that should not be merged Run Smoke E2E Triggers smoke e2e on Bitrise team-security
Projects
PR review queue
Status: Needs dev review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legobeat @metamaskbot @mcmire @codecov-commenter