Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade test failure fix for 7.24.0 release branch #9903

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

Andepande
Copy link
Member

@Andepande Andepande commented Jun 7, 2024

Description

  • updates the the Browserstack url for upgrade test
  • updates the wdio cucumber steps to match the expected process flow

Related issues

Fixes: This failure on Bitrise https://app.bitrise.io/build/273524f9-ffa0-4adf-a4ca-0f2e5f1a0694

Manual testing steps

  1. Run release_e2e_pipeline
  2. All tests should pass

Screenshots/Recordings

Before

https://app.bitrise.io/build/273524f9-ffa0-4adf-a4ca-0f2e5f1a0694

After

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5252a0f6-ecfe-405b-987e-bc33f37c5e74

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Andepande Andepande changed the title fix: Release/7.24.0 upgrade test update fix: upgrade test failure fix for 7.24.0 release branch Jun 7, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 7, 2024
@Andepande Andepande removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 7, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 7, 2024
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L merged commit 112007d into release/7.24.0 Jun 7, 2024
45 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
@metamaskbot metamaskbot added the release-7.24.3 Issue or pull request that will be included in release 7.24.3 label Jun 19, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.24.3 on PR, as PR was added to branch 7.24.3 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template regression-RC-7.24.0 release-7.24.3 Issue or pull request that will be included in release 7.24.3 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants