fix: cherry pick Duplicate accounts fix (#9943)

[owencraston]

This PR addresses the issue of duplicate accounts showing up in the wallet. This bug was introduced when the accounts controller was integrated but was only visible to users in this
PR when we started rendering account information in the accounts list. The is that when we ran migration 036.ts, we simply added the all of the identities from the preferences controller into the AccountsController. However the accounts controller also consumes addresses from the KeyringController and those addresses are in lowercase. The result would be two accounts with the same address, one in checksum format and one in lowercase format. This would result in duplicates when rendering the UI.

This PR addresses this issue in two ways...

1. for users who are using <= v7.19.0

• I have patched migration 36 to ensure that the addresses that are added are lowercase.

2. For users who have are using version >= 7.20.0 and are already effected by this bug

• I have created a new migration to deduplicate the accounts in the accounts controller and ensure that we are only storing lowercase addresses in state.

Fixes: #9823

• Current branch -
  7.18.0 -
  7.24.0

1. Install 7.18.0 and import a wallet with multiple addresses already
2. Install 7.24.0 and upgrade app.
3. EXPECTED: You should see duplicate accounts when you open the accounts list. If you had 5 accounts previously there will be should now be 10.
4. Install the current branch QA build and upgrade.
5. EXPECT: The duplicate accounts should be removed (back to 5 accounts from 10)
6. EXPECT: The previously selected address should still be selected
7. EXPECT: The account names should be in tact and in chronological order if they are the default account name.

this occurs for users who have not upgraded from 7.19.0 yet

1. Install 7.18.0 and import a wallet with multiple addresses already
2. Install the current branch QA build and upgrade.
3. EXPECT: All of the account should appear in the accounts list without duplicates
4. EXPECT: The previously selected address should be the same
5. EXPECT: The account names should be the same

7.18.0

After Upgrading to 7.24.0

Upgrading to this branch

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding
  Standards.

• I've completed the PR template to the best of my ability

• I’ve included tests if applicable

• I’ve documented my code using JSDoc format if applicable

• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).

• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0b07555
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0075ea1f-e8ad-4981-b6c9-7d426a1d458f

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sethkfman]

LGTM

[metamaskbot]

No release label on PR. Adding release label release-7.24.3 on PR, as PR was cherry-picked in branch 7.24.3.