Add RepositoryFilesystem #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When linting a project, we need to constantly read the files within either the module template or the project. We want this tool to run as fast as possible, and to do this, we can cache the metadata and content of each file that we read so that we don't have to do it again. This class assists with that.
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
mcmire
commented
Oct 26, 2023
| @@ -9,6 +9,9 @@ | |||
| "noEmit": true, | |||
| "noErrorTruncation": true, | |||
| "noUncheckedIndexedAccess": true, | |||
| "paths": { | |||
| "@metamask/utils/node": ["./node_modules/@metamask/utils/dist/types/node"] | |||
There was a problem hiding this comment.
The reason we're setting paths is explained here: #20 (comment)
Gudahtt
reviewed
Nov 6, 2023
Gudahtt
reviewed
Nov 6, 2023
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Gudahtt
previously approved these changes
Nov 7, 2023
|
^ Addressed merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When linting a project, we need to constantly read the files within either the module template or the project. We want this tool to run as fast as possible, and to do this, we can cache the metadata and content of each file that we read so that we don't have to do it again. This class assists with that.
Related to #5.
See here for context on how a RepositoryFilesystem will eventually be used: