Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logger argument to initializeProvider, log web3 shim usage #116

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Add logger argument to initializeProvider, log web3 shim usage #116

merged 2 commits into from
Dec 3, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Dec 3, 2020 •
edited
Loading

  • Add logger argument to initializeProvider
    • This is now passed on to the pre-existing logger argument of the inpage provider constructor
  • Calls the metamask_logWeb3ShimUsage RPC method whenever a property other than the shim id/flag or currentProvider is accessed.

@rekmarks rekmarks requested a review from a team as a code owner December 3, 2020 01:05
@rekmarks rekmarks requested a review from danjm December 3, 2020 01:05
rekmarks
rekmarks commented Dec 3, 2020
View reviewed changes
src/shimWeb3.js Outdated Show resolved Hide resolved
@rekmarks rekmarks changed the title Log web3 shim usage Add logger argument to initializeProvider, log web3 shim usage Dec 3, 2020
Gudahtt
Gudahtt approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit 72f9665 into main Dec 3, 2020
@rekmarks rekmarks deleted the log-web3-shim-usage branch December 3, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekmarks @Gudahtt