Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn wallet_watchAsset ERC721,ERC1155 #264

Merged
merged 12 commits into from
Jun 26, 2023
Merged

warn wallet_watchAsset ERC721,ERC1155 #264

merged 12 commits into from
Jun 26, 2023

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Jun 22, 2023

Adds a console.warn when wallet_watchAsset is called with params: {type: 'ERC721'} or params: {type: 'ERC1155'}.

Examples

@jiexi jiexi requested a review from a team as a code owner June 22, 2023 21:50
@jiexi jiexi requested a review from adonesky1 June 22, 2023 21:51
jiexi
jiexi commented Jun 22, 2023
View reviewed changes
src/messages.ts Outdated Show resolved Hide resolved
@adonesky1 adonesky1 requested review from mcmire and Gudahtt June 23, 2023 15:07
adonesky1
adonesky1 reviewed Jun 23, 2023
View reviewed changes
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question, and we just need to update that warning message and then I think we're good to go!

@socket-security
Copy link

socket-security bot commented Jun 23, 2023 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@jiexi
Copy link
Contributor Author

jiexi commented Jun 23, 2023

@metamask/controller-utils@4.0.0 is used in extension. Okay if we @SocketSecurity ignore-all the socket-security alerts?

adonesky1
adonesky1 reviewed Jun 23, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@adonesky1 adonesky1 requested a review from danjm June 26, 2023 15:32
adonesky1
adonesky1 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jiexi jiexi merged commit 715a188 into main Jun 26, 2023
16 checks passed
@jiexi jiexi deleted the jl/wallet_watchAsset-warning branch June 26, 2023 16:45
@adonesky1 adonesky1 mentioned this pull request Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vandan vandan vandan left review comments

@adonesky1 adonesky1 adonesky1 approved these changes

@mcmire mcmire Awaiting requested review from mcmire

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

@danjm danjm Awaiting requested review from danjm

@shanejonas shanejonas Awaiting requested review from shanejonas

@pedronfigueiredo pedronfigueiredo Awaiting requested review from pedronfigueiredo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jiexi @mcmire @shanejonas @vandan @pedronfigueiredo @adonesky1