Handle multiple link elements with rel=icon
#76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is very possible—even recommended—that there are multiple icons and if we're going to check that they actually exist, we should fallback to the other images listed. e.g.: ```html <link rel="icon" type="image/png" href="https://cdn.yourwebsite.com/favicon-16x16.png" sizes="16x16"> <link rel="icon" type="image/png" href="https://cdn.yourwebsite.com/favicon-32x32.png" sizes="32x32"> <link rel="icon" type="image/png" href="https://cdn.yourwebsite.com/favicon-96x96.png" sizes="96x96"> ``` There is a subtle functionality change here in that the element matching `head > link[rel="shortcut icon"]` will no longer be checked first, but that isn't important, nor should it be. That said, not checking for `rel="shortcut icon"` first could also be an improvement since its usage isn't quite correct or modern:<sup>[\[1\]][1]</sup> > For [historical reasons][2], the HTML specification [now allows][3] the use > of `shortcut` as a link relation if it’s immediately followed by a single > U+0020 space character and the `icon` keyword. [1]:https://mathiasbynens.be/notes/rel-shortcut-icon [2]:https://www.w3.org/Bugs/Public/show_bug.cgi?id=12695 [3]:https://html.spec.whatwg.org/multipage/semantics.html#rel-icon
whymarrh
force-pushed
the
check-all-icons
branch
from
30f848f
to
3e3a426
Compare
|
Fixed up the JSDoc |
rekmarks
approved these changes
Jul 21, 2020
|
Fixed up the JSDoc, again 😅 |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #75
It is very possible—even recommended—that there are multiple icons and if we're going to check that they actually exist, we should fallback to the other images listed.
e.g.:
There is a subtle functionality change here in that the element matching
head > link[rel="shortcut icon"]will no longer be checked first, but that isn't important, nor should it be. That said, not checking forrel="shortcut icon"first could also be an improvement since its usage isn't quite correct or modern:[1]