rename package to @metamask/react-native-webview #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
legobeat
force-pushed
the
metamask-namespace
branch
from
79ae5a1
to
3a49e4b
Compare
|
Not sure how to proceed with the erroring iOS/macOS builds - I guess the Podfile locks needs regeneration? Perhaps someone with access to a mac / Xcode can asssist? |
|
@jpcloureiro is the target branch of this PR correct? |
|
@legobeat yes, I'm looking into the iOS pod setup failures |
|
Podspec filename must match its name attribute Here's the commit with the changes to get pods to install |
@jpcloureiro Thanks! Merged: d05d525 |
This comment was marked as resolved.
This comment was marked as resolved.
legobeat
force-pushed
the
metamask-namespace
branch
from
d05d525
to
1687141
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
legobeat
force-pushed
the
metamask-namespace
branch
from
1687141
to
4ef3ddb
Compare
legobeat
added a commit
to legobeat/react-native-webview-mm
that referenced
this pull request
May 22, 2024
Follow-up to MetaMask#15, which renamed the file without updating the `files` entry in package manifest.
legobeat
added a commit
that referenced
this pull request
May 22, 2024
Follow-up to #15, which renamed the file without updating the `files` entry in package manifest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for publish as
@metamask/react-native-webview