Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devDeps: appium@^1.22.3->^2.5.4 #30

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

legobeat
Copy link

@legobeat legobeat commented May 23, 2024

Copy link

socket-security bot commented May 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@appium/schema@0.5.0 None +2 144 kB jlipps
npm/@colors/colors@1.6.0 environment 0 41.5 kB dabh
npm/@types/express@4.17.21 None +10 821 kB types
npm/ajv@8.12.0 eval Transitive: unsafe +3 1.57 MB esp
npm/appium@2.5.4 environment, filesystem, shell, unsafe Transitive: eval, network +252 245 MB jlipps
npm/archiver-utils@5.0.2 Transitive: environment, shell +31 2.16 MB ctalkington
npm/fast-fifo@1.3.2 None 0 5.07 kB mafintosh
npm/logform@2.6.0 None +4 211 kB dabh
npm/make-error@1.3.6 None 0 12.4 kB julien-f
npm/minipass@7.1.1 None 0 285 kB isaacs
npm/obuf@1.1.2 None 0 19.1 kB indutny
npm/path-scurry@1.11.1 filesystem +1 1.22 MB isaacs
npm/pkg-dir@5.0.0 Transitive: filesystem +3 27.7 kB sindresorhus
npm/shell-quote@1.8.1 None 0 45 kB ljharb
npm/tslib@2.6.2 None 0 84 kB typescript-bot
npm/wbuf@1.7.3 None +1 22.4 kB indutny

🚮 Removed packages: npm/@jimp/bmp@0.5.4, npm/@jimp/core@0.5.4, npm/@jimp/custom@0.5.4, npm/@jimp/gif@0.5.0, npm/@jimp/jpeg@0.5.4, npm/@jimp/plugin-blit@0.5.4, npm/@jimp/plugin-blur@0.5.0, npm/@jimp/plugin-circle@0.10.3, npm/@jimp/plugin-color@0.5.5, npm/@jimp/plugin-contain@0.5.4, npm/@jimp/plugin-cover@0.5.4, npm/@jimp/plugin-crop@0.5.4, npm/@jimp/plugin-displace@0.5.0, npm/@jimp/plugin-dither@0.5.0, npm/@jimp/plugin-fisheye@0.10.3, npm/@jimp/plugin-flip@0.5.0, npm/@jimp/plugin-gaussian@0.5.0, npm/@jimp/plugin-invert@0.5.0, npm/@jimp/plugin-mask@0.5.4, npm/@jimp/plugin-normalize@0.5.4, npm/@jimp/plugin-print@0.5.4, npm/@jimp/plugin-resize@0.5.4, npm/@jimp/plugin-rotate@0.5.4, npm/@jimp/plugin-scale@0.5.0, npm/@jimp/plugin-shadow@0.10.3, npm/@jimp/plugin-threshold@0.10.3, npm/@jimp/plugins@0.5.5, npm/@jimp/png@0.5.4, npm/@jimp/tiff@0.5.4, npm/@jimp/types@0.5.4, npm/@tokenizer/token@0.3.0, npm/@types/responselike@1.0.0, npm/appium-adb@8.7.0, npm/appium-android-driver@4.39.0, npm/appium-base-driver@7.2.0, npm/appium-chromedriver@4.25.1, npm/appium-idb@0.5.1, npm/appium-ios-device@1.8.0, npm/appium-ios-driver@4.7.0, npm/appium-ios-simulator@3.23.0, npm/appium-mac-driver@1.10.0, npm/appium-remote-debugger@4.5.0, npm/appium-support@2.48.1, npm/appium-uiautomator2-driver@1.57.0, npm/appium-webdriveragent@3.17.0, npm/appium-xcode@3.10.0, npm/appium-xcuitest-driver@3.62.0, npm/appium@1.22.3, npm/assert-plus@1.0.0, npm/async-lock@1.2.4, npm/async@2.6.4, npm/asyncbox@2.6.0, npm/big-integer@1.6.51, npm/colors@1.4.0, npm/core-js@2.6.11, npm/extsprintf@1.3.0, npm/file-type@9.0.0, npm/gifwrap@0.10.1, npm/http-errors@1.7.2, npm/isomorphic-fetch@3.0.0, npm/jimp@0.10.3, npm/jpeg-js@0.3.7, npm/js2xmlparser2@0.2.0, npm/load-bmfont@1.4.1, npm/moment-timezone@0.5.28, npm/node-simctl@6.3.0, npm/npmlog@4.1.2, npm/omggif@1.0.10, npm/peek-readable@4.1.0, npm/portfinder@1.0.28, npm/portscanner@2.2.0, npm/readable-web-to-node-stream@3.0.2, npm/request-promise@4.2.6, npm/request@2.88.2, npm/shared-preferences-builder@0.0.4, npm/shell-quote@1.7.3, npm/strtok3@6.3.0, npm/tar-stream@2.1.3, npm/teen_process@1.15.0, npm/token-types@4.2.1, npm/tslib@2.4.0, npm/tweetnacl@0.14.5, npm/utif2@4.1.0, npm/xmlbuilder@9.0.7, npm/xmldom@0.3.0, npm/yauzl@2.10.0

View full report↗︎

Copy link

socket-security bot commented May 23, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@appium/base-driver@9.6.0, npm/appium@2.5.4, npm/detect-libc@2.0.3, npm/foreground-child@3.1.1, npm/sharp@0.33.3, npm/spdy@4.0.2

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Author

@SocketSecurity ignore npm/appium@2.5.4

shell access, install scripts ok

@legobeat
Copy link
Author

@SocketSecurity ignore npm/foreground-child@3.1.1
@SocketSecurity ignore npm/detect-libc@2.0.3

shell access ok

@legobeat
Copy link
Author

@SocketSecurity ignore npm/spdy@4.0.2

network access ok

@legobeat legobeat marked this pull request as ready for review May 24, 2024 21:37
@legobeat legobeat requested review from naugtur, leotm, sethkfman, Cal-L, tommasini and a team May 24, 2024 21:38
@legobeat
Copy link
Author

@SocketSecurity ignore npm/@appium/base-driver@9.6.0

network access ok

@legobeat
Copy link
Author

@SocketSecurity ignore npm/sharp@0.33.3

install scripts ok

@legobeat legobeat added the dependencies Pull requests that update a dependency file label May 24, 2024
@legobeat legobeat requested a review from jpcloureiro May 24, 2024 21:40
@legobeat legobeat requested review from a team, sethkfman, jpcloureiro, Cal-L and leotm and removed request for sethkfman, leotm, Cal-L and jpcloureiro May 27, 2024 21:41
Copy link

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legobeat legobeat merged commit f2c9cfe into MetaMask:main May 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants