Android filename validation when downloading from browser #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
depends on #8 Ready do review after rebase |
tommasini
approved these changes
Mar 7, 2024
android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManagerImpl.kt
Show resolved
Hide resolved
chrisleewilcox
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Mar 20, 2024
… from browser (#8654) ## **Description** This change is part of the file react-native-webview+11.13.0.patch, a collection of patches that we need to apply on top of react-native-webview. Original Pull Request: [#6844](#6844) Webview changes can be reviewed here: [MetaMask/react-native-webview-mm#7](MetaMask/react-native-webview-mm#7) ``` Scenario: Download file with invalid file name Navigate to websites using browser address bar. Given the app displayed the splash animation And I have imported my wallet And I tap No Thanks on the Enable security check screen And I tap No thanks on the onboarding welcome tutorial And I navigate to the browser And I have 1 browser tab displayed When I download a file with invalid filename Then an error message should appear And the file is not download ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/MetaMask/metamask-mobile/assets/1649425/aa7d07a8-ab95-4f36-9325-bdcd6760dcd0 ### **After** https://github.com/MetaMask/metamask-mobile/assets/1649425/3e3fd1cf-5593-4afb-8045-4666cad494cd ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
QA Passed, Wait on #8 to merge |
jpcloureiro
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Mar 20, 2024
… from browser (#8654) This change is part of the file react-native-webview+11.13.0.patch, a collection of patches that we need to apply on top of react-native-webview. Original Pull Request: [#6844](#6844) Webview changes can be reviewed here: [MetaMask/react-native-webview-mm#7](MetaMask/react-native-webview-mm#7) ``` Scenario: Download file with invalid file name Navigate to websites using browser address bar. Given the app displayed the splash animation And I have imported my wallet And I tap No Thanks on the Enable security check screen And I tap No thanks on the onboarding welcome tutorial And I navigate to the browser And I have 1 browser tab displayed When I download a file with invalid filename Then an error message should appear And the file is not download ``` <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> https://github.com/MetaMask/metamask-mobile/assets/1649425/aa7d07a8-ab95-4f36-9325-bdcd6760dcd0 https://github.com/MetaMask/metamask-mobile/assets/1649425/3e3fd1cf-5593-4afb-8045-4666cad494cd - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.