Skip to content

Commit

Permalink
chore: Bump minimum Node version (#154)
Browse files Browse the repository at this point in the history
Bumps the minimum node version from 16 to 18, updates the minimum
versions for 18, 20, and 22.
  • Loading branch information
rekmarks authored Sep 27, 2024
1 parent 1b7e953 commit 39b34e2
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 11 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-lint-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
- prepare
strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
node-version: [18.x, 20.x, 22.x]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand All @@ -99,7 +99,7 @@ jobs:
- prepare
strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
node-version: [18.x, 20.x, 22.x]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ const message5 = getMessageFromCode(code2);

### Setup

- Install [Node.js](https://nodejs.org) version 16
- Install [Node.js](https://nodejs.org) version 18
- If you are using [nvm](https://github.com/creationix/nvm#installation) (recommended) running `nvm use` will automatically choose the right node version for you.
- Install [Yarn v3](https://yarnpkg.com/getting-started/install)
- Run `yarn install` to install dependencies and run any required post-install scripts
Expand Down
2 changes: 1 addition & 1 deletion constraints.pro
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ gen_enforced_dependency(WorkspaceCwd, DependencyIdent, null, DependencyType) :-
DependencyType == 'devDependencies'.

% The package must specify the expected node version constraint.
gen_enforced_field(WorkspaceCwd, 'engines.node', '>=16.0.0').
gen_enforced_field(WorkspaceCwd, 'engines.node', '^18.20 || ^20.17 || >=22').

% The package is public.
gen_enforced_field(WorkspaceCwd, 'publishConfig.access', 'public').
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"@metamask/eslint-config-typescript": "^12.1.0",
"@ts-bridge/cli": "^0.5.1",
"@types/jest": "^28.1.6",
"@types/node": "^16",
"@types/node": "^18",
"@typescript-eslint/eslint-plugin": "^5.43.0",
"@typescript-eslint/parser": "^5.43.0",
"depcheck": "^1.4.7",
Expand All @@ -88,7 +88,7 @@
},
"packageManager": "yarn@3.2.4",
"engines": {
"node": ">=16.0.0"
"node": "^18.20 || ^20.17 || >=22"
},
"publishConfig": {
"access": "public",
Expand Down
19 changes: 14 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1018,7 +1018,7 @@ __metadata:
"@metamask/utils": ^9.0.0
"@ts-bridge/cli": ^0.5.1
"@types/jest": ^28.1.6
"@types/node": ^16
"@types/node": ^18
"@typescript-eslint/eslint-plugin": ^5.43.0
"@typescript-eslint/parser": ^5.43.0
depcheck: ^1.4.7
Expand Down Expand Up @@ -1473,10 +1473,12 @@ __metadata:
languageName: node
linkType: hard

"@types/node@npm:*, @types/node@npm:^16":
version: 16.18.82
resolution: "@types/node@npm:16.18.82"
checksum: ace573877c3fe2fad4004a85b1ec72812eef43718a89cea92370777505954dfa59f44cf65db90217f977f2207e4c5de399eb81ab0006e3f7ff57388f585b4fb1
"@types/node@npm:*, @types/node@npm:^18":
version: 18.19.54
resolution: "@types/node@npm:18.19.54"
dependencies:
undici-types: ~5.26.4
checksum: d85bacc7430c2913bcd2cf293f312bc1f9108819707ac25b58404185c3b8f9ca9e3e93c396672f457c18e65f5ba86cc8363803f830207c6b7dd14fd74e1455b0
languageName: node
linkType: hard

Expand Down Expand Up @@ -6978,6 +6980,13 @@ __metadata:
languageName: node
linkType: hard

"undici-types@npm:~5.26.4":
version: 5.26.5
resolution: "undici-types@npm:5.26.5"
checksum: 3192ef6f3fd5df652f2dc1cd782b49d6ff14dc98e5dced492aa8a8c65425227da5da6aafe22523c67f035a272c599bb89cfe803c1db6311e44bed3042fc25487
languageName: node
linkType: hard

"unique-filename@npm:^2.0.0":
version: 2.0.1
resolution: "unique-filename@npm:2.0.1"
Expand Down

0 comments on commit 39b34e2

Please sign in to comment.