Remove networkId #191
Merged
Remove networkId #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiexi
commented
Aug 29, 2023
|
@metamaskbot publish-preview |
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
mcmire
reviewed
Aug 30, 2023
shanejonas
previously approved these changes
Sep 11, 2023
|
Needs the previews replaced with the releases, but looks good otherwise |
|
Blocked until MetaMask/core#1633 is merged and released |
legobeat
reviewed
Sep 25, 2023
adonesky1
reviewed
Sep 26, 2023
adonesky1
previously approved these changes
Sep 26, 2023
adonesky1
approved these changes
Sep 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wallets shouldn't be directly concerned about the network ID as this more of a p2p concept for gossip. What wallets really care about is chain ID as that is the correct value to use to identify a chain, build transactions, etc. Although these two values usually match (ignoring hex/dec formatting), there are exceptions.
We want to remove usage of
networkIdfrom the SmartTransactionController.