Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add many unit tests, support for the batch_status API, refactoring #6

Merged
merged 4 commits into from
Sep 20, 2021
Merged

Add many unit tests, support for the batch_status API, refactoring #6

merged 4 commits into from
Sep 20, 2021

Conversation

dan437
Copy link
Collaborator

@dan437 dan437 commented Sep 17, 2021

Description

This PR includes:

  • Many unit tests
  • Support for the batch_status API
  • Run Jest coverage in the watch mode
  • Increase Jest coverage threshold to ~90%
  • Refactoring

Screenshots

image

@dan437 dan437 requested a review from a team as a code owner September 17, 2021 13:43
wachunei
wachunei approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🆗

@dan437 dan437 merged commit fd61a4b into main Sep 20, 2021
@rekmarks rekmarks deleted the unit-tests branch October 20, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wachunei wachunei wachunei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan437 @wachunei