Remove unnecessary event props #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes unnecessary props, which are no longer needed for making our product better. We added them initially because we thought they could be useful for debugging. We have also just noticed that token_from_address and token_to_address fields don't even use correct values. All these 3 event props are not needed, so we are removing them and we will also clean them up in our database. This issue affected a small subset of users who opted in MetaMetrics and submitted transactions through our embedded Swaps feature with Smart Transactions enabled.
If you think we have somewhere in MM an unnecessary event prop, let us please know via GitHub issue.