This repository has been archived by the owner on Sep 9, 2021. It is now read-only.
Improve test coverage #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
force-pushed
the
increase-test-coverage
branch
from
e5f378b
to
dd695b8
Compare
Merged
rekmarks
added a commit
that referenced
this pull request
Sep 6, 2021
The scripts in `development` were previously migrated to TypeScript. They were somewhat broken. This PR makes them plain JavaScript again, and removes them from the build output. This alters the structure of `dist`, which has been taken into account. This also fixes a bug introduced in #126, due to `evalWorker.ts` being renamed to `eval-worker.ts`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #74.
This PR adds unit tests for
cli.ts, and achieves 100% coverage for everything except branches, which are left at 86%. The lower branch coverage is mainly due to solitaryifstatements inmanifestHandler.tswhose implicitelseclauses are never tested.In order to achieve the increased test coverage, some internal files have been refactored. All changes should be non-breaking.