Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screenshots field #505

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Add screenshots field #505

merged 4 commits into from
Mar 20, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Mar 20, 2024

This adds support for a screenshots field in the registry. Snaps may have three screenshots, with a size of 960x540. Screenshots should be placed in src/images/<snapId>, i.e., src/images/@organisation/snap-name, and should be named 1.png, 2.png, 3.png (or .jpe?g). They can then be added to the registry by adding screenshots to the metadata, with the path to each file as array items.

{
  "verifiedSnaps": {
    "npm:@organisation/snap-name": {
      "metadata": {
        "screenshots": [
          "./images/@organisation/snap-name/1.png",
          "./images/@organisation/snap-name/2.png",
          "./images/@organisation/snap-name/3.png"
        ]
      }
    }
  }
}

@Mrtenz Mrtenz requested a review from a team as a code owner March 20, 2024 14:39
src/index.ts Outdated Show resolved Hide resolved
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/image-size@1.1.1 filesystem 0 50 kB netroy
npm/queue@6.0.2 None 0 17.6 kB jessetane

View full report↗︎

@Mrtenz Mrtenz merged commit 3fd9bf7 into main Mar 20, 2024
16 checks passed
@Mrtenz Mrtenz deleted the mrtenz/screenshots branch March 20, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants