Made typescript type-checking in the cli into a config option

MetaMask · Oct 6, 2024 · 1ab5a3d · 1ab5a3d
1 parent 7f1740e
commit 1ab5a3d
Show file tree

Hide file tree

Showing 56 changed files with 158 additions and 41 deletions.
diff --git a/packages/examples/packages/bip32/snap.config.ts b/packages/examples/packages/bip32/snap.config.ts
@@ -6,6 +6,9 @@ const config: SnapConfig = {
   server: {
     port: 8001,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
     builtIns: {

diff --git a/packages/examples/packages/bip32/src/index.ts b/packages/examples/packages/bip32/src/index.ts
@@ -40,14 +40,13 @@ import { getPrivateNode, getPublicKey } from './utils';
 export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
   switch (request.method) {
     case 'getPublicKey':
-      return await getPublicKey(
-        request.params as unknown as GetBip32PublicKeyParams,
-      );
+      return await getPublicKey(request.params as GetBip32PublicKeyParams);
 
     case 'signMessage': {
       const { message, curve, ...params } = request.params as SignMessageParams;
 
       if (!message || typeof message !== 'string') {
+        // eslint-disable-next-line @typescript-eslint/no-throw-literal
         throw new InvalidParamsError(`Invalid signature data: "${message}".`);
       }
 
@@ -75,6 +74,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
       });
 
       if (!approved) {
+        // eslint-disable-next-line @typescript-eslint/no-throw-literal
         throw new UserRejectedRequestError();
       }
 
@@ -100,6 +100,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
     }
 
     default:
+      // eslint-disable-next-line @typescript-eslint/no-throw-literal
       throw new MethodNotFoundError({ method: request.method });
   }
 };
diff --git a/packages/examples/packages/bip44/snap.config.ts b/packages/examples/packages/bip44/snap.config.ts
@@ -6,6 +6,9 @@ const config: SnapConfig = {
   server: {
     port: 8002,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
     builtIns: {

diff --git a/packages/examples/packages/bip44/src/index.ts b/packages/examples/packages/bip44/src/index.ts
@@ -59,6 +59,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
       });
 
       if (!approved) {
+        // eslint-disable-next-line @typescript-eslint/no-throw-literal
         throw new UserRejectedRequestError();
       }
 
@@ -67,6 +68,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
     }
 
     default:
+      // eslint-disable-next-line @typescript-eslint/no-throw-literal
       throw new MethodNotFoundError({ method: request.method });
   }
 };
diff --git a/packages/examples/packages/browserify-plugin/src/index.ts b/packages/examples/packages/browserify-plugin/src/index.ts
@@ -23,6 +23,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
       return 'Hello from Browserify!';
 
     default: {
+      // eslint-disable-next-line @typescript-eslint/no-throw-literal
       throw new MethodNotFoundError({ method: request.method });
     }
   }

diff --git a/packages/examples/packages/browserify/src/index.ts b/packages/examples/packages/browserify/src/index.ts
@@ -25,6 +25,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
       return 'Hello from the MetaMask Snaps CLI using Browserify!';
 
     default: {
+      // eslint-disable-next-line @typescript-eslint/no-throw-literal
       throw new MethodNotFoundError({ method: request.method });
     }
   }

diff --git a/packages/examples/packages/client-status/snap.config.ts b/packages/examples/packages/client-status/snap.config.ts
@@ -6,6 +6,9 @@ const config: SnapConfig = {
   server: {
     port: 8027,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
   },

diff --git a/packages/examples/packages/client-status/src/index.ts b/packages/examples/packages/client-status/src/index.ts
@@ -23,6 +23,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
     }
 
     default:
+      // eslint-disable-next-line @typescript-eslint/no-throw-literal
       throw new MethodNotFoundError({ method: request.method });
   }
 };
diff --git a/packages/examples/packages/cronjobs/snap.config.ts b/packages/examples/packages/cronjobs/snap.config.ts
@@ -6,6 +6,9 @@ const config: SnapConfig = {
   server: {
     port: 8004,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
   },

diff --git a/packages/examples/packages/cronjobs/src/index.ts b/packages/examples/packages/cronjobs/src/index.ts
@@ -30,6 +30,7 @@ export const onCronjob: OnCronjobHandler = async ({ request }) => {
         },
       });
     default:
+      // eslint-disable-next-line @typescript-eslint/no-throw-literal
       throw new MethodNotFoundError({ method: request.method });
   }
 };
diff --git a/packages/examples/packages/dialogs/snap.config.ts b/packages/examples/packages/dialogs/snap.config.ts
@@ -6,6 +6,9 @@ const config: SnapConfig = {
   server: {
     port: 8005,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
   },

diff --git a/packages/examples/packages/dialogs/src/index.tsx b/packages/examples/packages/dialogs/src/index.tsx
@@ -91,6 +91,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
       });
 
     default:
+      // eslint-disable-next-line @typescript-eslint/no-throw-literal
       throw new MethodNotFoundError({ method: request.method });
   }
 };

diff --git a/packages/examples/packages/errors/snap.config.ts b/packages/examples/packages/errors/snap.config.ts
@@ -6,6 +6,9 @@ const config: SnapConfig = {
   server: {
     port: 8006,
   },
+  typescript: {
+    enabled: true,
+  },
 };
 
 export default config;
diff --git a/packages/examples/packages/ethereum-provider/snap.config.ts b/packages/examples/packages/ethereum-provider/snap.config.ts
@@ -6,6 +6,9 @@ const config: SnapConfig = {
   server: {
     port: 8007,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
   },

diff --git a/packages/examples/packages/ethereum-provider/src/index.ts b/packages/examples/packages/ethereum-provider/src/index.ts
@@ -123,6 +123,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
     }
 
     default:
+      // eslint-disable-next-line @typescript-eslint/no-throw-literal
       throw new MethodNotFoundError({ method: request.method });
   }
 };
diff --git a/packages/examples/packages/ethers-js/snap.config.ts b/packages/examples/packages/ethers-js/snap.config.ts
@@ -8,6 +8,9 @@ const config: SnapConfig = {
   server: {
     port: 8008,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
     builtIns: {

diff --git a/packages/examples/packages/file-upload/snap.config.ts b/packages/examples/packages/file-upload/snap.config.ts
@@ -6,6 +6,9 @@ const config: SnapConfig = {
   server: {
     port: 8030,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
   },

diff --git a/packages/examples/packages/file-upload/src/index.tsx b/packages/examples/packages/file-upload/src/index.tsx
@@ -44,6 +44,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
     }
 
     default:
+      // eslint-disable-next-line @typescript-eslint/no-throw-literal
       throw new MethodNotFoundError({
         method: request.method,
       });

diff --git a/packages/examples/packages/get-entropy/snap.config.ts b/packages/examples/packages/get-entropy/snap.config.ts
@@ -6,6 +6,9 @@ const config: SnapConfig = {
   server: {
     port: 8009,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
     builtIns: {

diff --git a/packages/examples/packages/get-entropy/src/index.ts b/packages/examples/packages/get-entropy/src/index.ts
@@ -48,6 +48,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
       });
 
       if (!approved) {
+        // eslint-disable-next-line @typescript-eslint/no-throw-literal
         throw new UserRejectedRequestError();
       }
 
@@ -57,6 +58,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
     }
 
     default:
+      // eslint-disable-next-line @typescript-eslint/no-throw-literal
       throw new MethodNotFoundError({ method: request.method });
   }
 };
diff --git a/packages/examples/packages/get-file/snap.config.ts b/packages/examples/packages/get-file/snap.config.ts
@@ -6,6 +6,9 @@ const config: SnapConfig = {
   server: {
     port: 8024,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
   },

diff --git a/packages/examples/packages/get-file/src/index.ts b/packages/examples/packages/get-file/src/index.ts
@@ -47,6 +47,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
     }
 
     default:
+      // eslint-disable-next-line @typescript-eslint/no-throw-literal
       throw new MethodNotFoundError({ method: request.method });
   }
 };
diff --git a/packages/examples/packages/home-page/snap.config.ts b/packages/examples/packages/home-page/snap.config.ts
@@ -6,6 +6,9 @@ const config: SnapConfig = {
   server: {
     port: 8025,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
   },

diff --git a/packages/examples/packages/home-page/src/index.test.tsx b/packages/examples/packages/home-page/src/index.test.tsx
@@ -12,7 +12,7 @@ describe('onHomePage', () => {
 
     await screen.clickElement('footer_button');
 
-    const newUi = await response.getInterface();
+    const newUi = response.getInterface();
 
     expect(newUi).toRender(
       <Box>

diff --git a/packages/examples/packages/images/snap.config.ts b/packages/examples/packages/images/snap.config.ts
@@ -5,6 +5,9 @@ const config: SnapConfig = {
   server: {
     port: 8026,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
   },

diff --git a/packages/examples/packages/images/src/index.ts b/packages/examples/packages/images/src/index.ts
@@ -104,6 +104,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
     }
 
     default:
+      // eslint-disable-next-line @typescript-eslint/no-throw-literal
       throw new MethodNotFoundError({ method: request.method });
   }
 };
diff --git a/packages/examples/packages/interactive-ui/snap.config.ts b/packages/examples/packages/interactive-ui/snap.config.ts
@@ -6,6 +6,9 @@ const config: SnapConfig = {
   server: {
     port: 8028,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
   },

diff --git a/packages/examples/packages/interactive-ui/src/index.tsx b/packages/examples/packages/interactive-ui/src/index.tsx
@@ -42,6 +42,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
     }
 
     default:
+      // eslint-disable-next-line @typescript-eslint/no-throw-literal
       throw new MethodNotFoundError({
         method: request.method,
       });

diff --git a/packages/examples/packages/invoke-snap/packages/consumer-signer/snap.config.ts b/packages/examples/packages/invoke-snap/packages/consumer-signer/snap.config.ts
@@ -6,6 +6,9 @@ const config: SnapConfig = {
   server: {
     port: 8012,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
   },

diff --git a/packages/examples/packages/invoke-snap/packages/core-signer/snap.config.ts b/packages/examples/packages/invoke-snap/packages/core-signer/snap.config.ts
@@ -6,6 +6,9 @@ const config: SnapConfig = {
   server: {
     port: 8011,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
     builtIns: {

diff --git a/packages/examples/packages/json-rpc/snap.config.ts b/packages/examples/packages/json-rpc/snap.config.ts
@@ -5,6 +5,9 @@ const config: SnapConfig = {
   server: {
     port: 8013,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
   },

diff --git a/packages/examples/packages/json-rpc/src/index.ts b/packages/examples/packages/json-rpc/src/index.ts
@@ -61,6 +61,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
     }
 
     default:
+      // eslint-disable-next-line @typescript-eslint/no-throw-literal
       throw new MethodNotFoundError({ method: request.method });
   }
 };
diff --git a/packages/examples/packages/jsx/snap.config.ts b/packages/examples/packages/jsx/snap.config.ts
@@ -6,6 +6,9 @@ const config: SnapConfig = {
   server: {
     port: 8029,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
   },

diff --git a/packages/examples/packages/lifecycle-hooks/snap.config.ts b/packages/examples/packages/lifecycle-hooks/snap.config.ts
@@ -5,6 +5,9 @@ const config: SnapConfig = {
   server: {
     port: 8022,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
   },

diff --git a/packages/examples/packages/localization/snap.config.ts b/packages/examples/packages/localization/snap.config.ts
@@ -5,6 +5,9 @@ const config: SnapConfig = {
   server: {
     port: 8020,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
   },

diff --git a/packages/examples/packages/localization/src/index.ts b/packages/examples/packages/localization/src/index.ts
@@ -23,6 +23,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
       return await getMessage('hello');
 
     default:
+      // eslint-disable-next-line @typescript-eslint/no-throw-literal
       throw new MethodNotFoundError({ method: request.method });
   }
 };
diff --git a/packages/examples/packages/manage-state/snap.config.ts b/packages/examples/packages/manage-state/snap.config.ts
@@ -5,6 +5,9 @@ const config: SnapConfig = {
   server: {
     port: 8014,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
   },

diff --git a/packages/examples/packages/manage-state/src/index.ts b/packages/examples/packages/manage-state/src/index.ts
@@ -53,6 +53,7 @@ export const onRpcRequest: OnRpcRequestHandler = async ({ request }) => {
     }
 
     default:
+      // eslint-disable-next-line @typescript-eslint/no-throw-literal
       throw new MethodNotFoundError({ method: request.method });
   }
 };
diff --git a/packages/examples/packages/name-lookup/snap.config.ts b/packages/examples/packages/name-lookup/snap.config.ts
@@ -5,6 +5,9 @@ const config: SnapConfig = {
   server: {
     port: 8023,
   },
+  typescript: {
+    enabled: true,
+  },
   stats: {
     buffer: false,
   },