Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onKeyringRequest to snaps-jest #2777

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

david0xd
Copy link
Contributor

@david0xd david0xd commented Oct 1, 2024

Add possibility to test onKeyringRequest with snaps-jest.

Fixes: #2775

@david0xd david0xd self-assigned this Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.42%. Comparing base (6cc4791) to head (b883cdd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2777   +/-   ##
=======================================
  Coverage   94.41%   94.42%           
=======================================
  Files         482      482           
  Lines       10261    10269    +8     
  Branches     1563     1563           
=======================================
+ Hits         9688     9696    +8     
  Misses        573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Keyring request object with params.
*/
request: object({
params: JsonRpcParamsStruct,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need method as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add keyring handler to snaps-jest
2 participants