Add new validation and limit for storage #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
requested changes
Jul 13, 2022
| @@ -87,6 +92,8 @@ export enum ManageStateOperation { | |||
| updateState = 'update', | |||
| } | |||
|
|
|||
| export const STORAGE_SIZE_LIMIT = 10000; // In bytes | |||
There was a problem hiding this comment.
We should decide with the team what this value should be.
There was a problem hiding this comment.
This is now limited with 100MB in size, as discussed on standup call.
david0xd
force-pushed
the
dd/snaps-storage-limit
branch
from
1f234f4
to
5441eac
Compare
Return isObject check Update utils version Return old message Refactor and change size limit
david0xd
force-pushed
the
dd/snaps-storage-limit
branch
from
5441eac
to
06bf370
Compare
Codecov Report
@@ Coverage Diff @@
## main #621 +/- ##
=======================================
Coverage 87.57% 87.57%
=======================================
Files 88 88
Lines 2664 2664
Branches 488 488
=======================================
Hits 2333 2333
Misses 311 311
Partials 20 20 Continue to review full report at Codecov.
|
FrederikBolding
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to enforce JSON serializability of the Snap state and limit its size.
This PR will introduce new utility functions for JSON sizing and validation implemented here: MetaMask/utils#14
Fix: #209
Fixes: #571