Send valid JSON-RPC notifications from executors #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
requested changes
Jul 18, 2022
packages/controllers/src/services/AbstractExecutionService.test.ts
Outdated
Show resolved
Hide resolved
packages/controllers/src/services/AbstractExecutionService.test.ts
Outdated
Show resolved
Hide resolved
|
Also needs a rebase now @rekmarks ! |
…t.ts Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
…t.ts Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
rekmarks
force-pushed
the
use-real-notifications
branch
from
1785137
to
b3f25ac
Compare
FrederikBolding
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseSnapExecutor.notify()was sending invalid JSON-RPC notifications to the execution service over the command stream. This PR ensures that only valid notifications are sent.