Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add buttons to deploy a contract that will always fail when sending a transaction to it #135 #139

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Add buttons to deploy a contract that will always fail when sending a transaction to it #135 #139

merged 2 commits into from
Dec 9, 2021

Conversation

dragana8
Copy link
Contributor

@ghost
Copy link

ghost commented Nov 30, 2021

Verified by QA

david0xd
david0xd previously approved these changes Dec 1, 2021
View reviewed changes
@dragana8 dragana8 marked this pull request as ready for review December 1, 2021 12:09
@dragana8 dragana8 requested a review from a team as a code owner December 1, 2021 12:09
david0xd
david0xd previously approved these changes Dec 1, 2021
View reviewed changes
danjm
danjm previously approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@danjm
Copy link
Contributor

danjm commented Dec 2, 2021

ooh, there are some merge conflicts to address

@dragana8 dragana8 dismissed stale reviews from danjm and david0xd via 3ed054d December 9, 2021 09:48
@danjm danjm merged commit c11d0f0 into MetaMask:main Dec 9, 2021
@brad-decker brad-decker mentioned this pull request Feb 3, 2022
Merged
@PeterYinusa PeterYinusa mentioned this pull request Mar 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danjm danjm danjm approved these changes

@david0xd david0xd david0xd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dragana8 @danjm @david0xd