Collectibles -> Nfts #237
Merged
Collectibles -> Nfts #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
commented
Jun 13, 2023
Comment on lines
+689
to
+714
| watchNFTsButton.onclick = async () => { | ||
| const currentTokenId = await nftsContract.currentTokenId(); | ||
| const nftsContractAddress = nftsContract.address; | ||
| let watchNftsResult; | ||
| try { | ||
| watchNftsResult = await ethereum.sendAsync( | ||
| Array.from({ length: currentTokenId }, (_, i) => i + 1).map( | ||
| (tokenId) => { | ||
| return { | ||
| method: 'wallet_watchAsset', | ||
| params: { | ||
| type: 'ERC721', | ||
| options: { | ||
| address: nftsContractAddress, | ||
| tokenId, | ||
| }, | ||
| }, | ||
| }; | ||
| }, | ||
| ), | ||
| ); | ||
| } catch (error) { | ||
| console.error(error); | ||
| } | ||
| console.log(watchNftsResult); | ||
| }; |
There was a problem hiding this comment.
This change is slightly unrelated. It is simply moving this onclick handler outside of the mintButton onclick handler so that it can be used to watch already minted NFTs when you pass a contract address to the dapp via url query string (without calling a new mint in that session).
PeterYinusa
approved these changes
Jun 13, 2023
digiwand
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the extension we have dropped use of the term
collectiblein favor ofnft. This PR simply updates the test-dapp to unify our terminology.This will require updating our e2e tests to look grab the new text.