Fix Network ID incorrectly using chainId value #256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
chainChanged
event was being used as the network ID value. This is incorrect, as chain ID and network ID values may not match and are not guaranteed to be interchangeable. This PR fixes this issue by:chainChanged
event to update both chainId and networkIdnetworkChanged
event to update both chainId and networkIdnetworkChanged
is deprecated, but there is no other way to guarantee we don't miss a network ID change