Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add token contract addresses and consolidate names #332

Merged
merged 1 commit into from
May 14, 2024

Conversation

seaona
Copy link
Contributor

@seaona seaona commented May 14, 2024

Description

In this PR we add a section for displaying the contract address(es) for ERC721 and ERC1155 tokens, in the same way as we do for ERC20 tokens.

Screenshot from 2024-05-14 11-57-27

Taking the opportunity for consolidating a couple of titles, for the different tokens, so we always follow the same pattern.

Screenshots

ERC721 before

Screenshot from 2024-05-14 11-47-14

ERC721 now

Screenshot from 2024-05-14 11-45-37

========================================================
ERC1155 before

Screenshot from 2024-05-14 11-47-57

ERC1155 now

Screenshot from 2024-05-14 11-45-46

Manual QA

  1. Deploy an ERC721 token --> see token address is displayed in the new section
  2. Deploy a second ERC721 token --> see the two token addresses displayed in the new section
  3. Deploy an ERC1155 token --> see token address is displayed in the new section
  4. Deploy a second ERC1155 token --> see the two token addresses displayed in the new section

@seaona seaona merged commit 2e9cfd7 into main May 14, 2024
7 checks passed
@seaona seaona deleted the token-contract-addresses branch May 14, 2024 11:13
@seaona seaona mentioned this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants