Fix JsonRpcRequest to be valid json #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
force-pushed
the
fix-jsonrpcparams-no-undefined
branch
from
2e2f5d4
to
0018d5b
Compare
legobeat
force-pushed
the
fix-jsonrpcparams-no-undefined
branch
2 times, most recently
from
e1e1ba4
to
1e421de
Compare
legobeat
changed the title
fix/types: JsonRpcParams should be valid JSON values `undefined` is not valid JSON. https://www.ecma-international.org/publications/files/ECMA-ST/ECMA-404.pdf (Section 5): A JSON value can be an object, array, number, string, true, false, or null.
legobeat
force-pushed
the
fix-jsonrpcparams-no-undefined
branch
from
1e421de
to
4e5c07f
Compare
This was referenced Aug 24, 2023
legobeat
requested review from
mcmire,
FrederikBolding,
Gudahtt,
Mrtenz,
rekmarks and
mikesposito
and removed request for
FrederikBolding
FrederikBolding
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix/types: JsonRpcParams should be valid JSON values
undefinedis not valid JSON.https://www.ecma-international.org/publications/files/ECMA-ST/ECMA-404.pdf (Section 5):
Resolves: #129
Related type error: https://github.com/MetaMask/providers/actions/runs/5959652471/job/16165741468?pr=275