Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JSON-RPC params type #17

Closed
wants to merge 1 commit into from
Closed

Improve JSON-RPC params type #17

wants to merge 1 commit into from

Conversation

FrederikBolding
Copy link
Member

JSON-RPC parameters can be specified either as an object or as an array, this PR changes the types to expect that.

See https://www.jsonrpc.org/specification#request_object 4.2 for reference.

@FrederikBolding FrederikBolding requested a review from a team as a code owner July 26, 2022 13:26
mcmire
mcmire approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This makes sense to me.

@mcmire
Copy link
Contributor

mcmire commented Aug 19, 2022 •
edited
Loading

@FrederikBolding I want to release a 3.0.0 version with #20 and #21 in it — do you want to get this in too?

@Mrtenz
Copy link
Member

Mrtenz commented Aug 19, 2022

@mcmire I'm pretty sure this is already done as part of #19.

@FrederikBolding
Copy link
Member Author

If so, feel free to close @Mrtenz

@Mrtenz Mrtenz closed this Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

Assignees

@Mrtenz Mrtenz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrederikBolding @mcmire @Mrtenz