Add util functions for encoding and decoding bytes #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
commented
Oct 1, 2022
ritave
reviewed
Oct 1, 2022
ritave
reviewed
Oct 1, 2022
ritave
reviewed
Oct 2, 2022
| assert(bytes > 0); | ||
|
|
||
| /* eslint-disable no-bitwise */ | ||
| const mask = value >> BigInt(31); |
| for (let i = 0; i < bytes.length; i++) { | ||
| bytes[i] = Number(BigInt.asUintN(8, numberValue)); | ||
| // eslint-disable-next-line no-bitwise | ||
| numberValue >>= BigInt(8); |
Mrtenz
force-pushed
the
mrtenz/byte-utils
branch
from
4755293
to
2716e71
Compare
ritave
approved these changes
Oct 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some util functions for working with bytes (
Uint8Array). These implementations don't rely on the Node.jsBufferclass, meaning that it does not require a polyfill to be used in browsers.These functions are implemented with performance in mind, so a faster implementation was chosen over a "pretty" implementation.