Add PendingJsonRpcResponse type
#43
Conversation
| { | ||
| id: 1, | ||
| jsonrpc: '2.0', | ||
| result: { | ||
| foo: 'bar', | ||
| }, | ||
| error: { | ||
| code: -32000, | ||
| message: 'Internal error', | ||
| }, |
There was a problem hiding this comment.
The original type in @metamask/types allows this. Please verify that this is intended, as I'm not sure where PendingJsonRpcResponse is used.
There was a problem hiding this comment.
It appears that this is intended behavior. PendingJsonRpcResponse was created to represent a response object within middleware. The idea here is that while a request is being sent through layers of a middleware stack, we don't know what the final response object will be — we don't know whether it will end up representing a successful or failed response. So PendingJsonRpcResponse is like the Schrodinger's cat of responses. It looks like the possibility that both result and error could be set was acknowledged but accepted as a compromise to prevent from having to typecast the response in middleware: MetaMask/json-rpc-engine#75
Mrtenz
force-pushed
the
mrtenz/pending-json-rpc-response
branch
from
1595860
to
d0479d0
Compare
Closes #39.
This adds a type and validation for
PendingJsonRpcResponse.