Add frozen collections #5
Conversation
rekmarks
force-pushed
the
frozen-collections
branch
from
cadc8a2
to
3dfbfd7
Compare
|
Edit: This issue has been resolved. |
rekmarks
force-pushed
the
frozen-collections
branch
from
124ca1a
to
931bd2a
Compare
| return this.#map[Symbol.iterator](); | ||
| } | ||
|
|
||
| constructor(entries?: readonly (readonly [Key, Value])[] | null) { |
There was a problem hiding this comment.
Why the double readonly? Just curious.
There was a problem hiding this comment.
What do you think about putting the constructor above get size and the iterator method?
There was a problem hiding this comment.
On mobile right now, but IIRC readonly isn't recursive, so the double was necessary.
Regarding the place of getters etc., we've been putting properties before the construction by convention (or necessity?), and getters seem more conceptually similar to properties than methods. Class "item" (what's the word for properties and methods?) order is not something we've ever standardized, although it would be cool if we had a lint rule that imposed some kind of order.
There was a problem hiding this comment.
I'm pretty agnostic about where the properties go, but I merged this so as to not lost the approvals. Maybe we can create an issue on the lint config?
| return this.#set[Symbol.iterator](); | ||
| } | ||
|
|
||
| constructor(values?: readonly Value[] | null) { |
There was a problem hiding this comment.
What do you think about putting this at the top of the class?
Add
FrozenMapandFrozenSet, which are like theirReadonlycounterparts except it is actually impossible to modify them.