Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versions and checksums #67

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Conversation

FrederikBolding
Copy link
Member

Adds version and checksum types and utilities currently primarily used in snaps-monorepo.

@FrederikBolding FrederikBolding requested a review from a team as a code owner January 4, 2023 13:25
@legobeat
Copy link
Contributor

legobeat commented Jan 4, 2023

The semver types seem to only really get useful with accompanying functions like satisifesVersionRange - is there a reason why those are not included here?

@FrederikBolding
Copy link
Member Author

The semver types seem to only really get useful with accompanying functions like satisifesVersionRange - is there a reason why those are not included here?

The PR was created because the types were needed elsewhere, but I see your point. I could add the other versioning utility methods to this PR!

ritave
ritave previously approved these changes Jan 4, 2023
src/base64.ts Outdated Show resolved Hide resolved
src/base64.ts Outdated Show resolved Hide resolved
@FrederikBolding FrederikBolding merged commit f5e139e into main Jan 5, 2023
@FrederikBolding FrederikBolding deleted the fb/add-versions-and-checksums branch January 5, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants