-
-
Notifications
You must be signed in to change notification settings - Fork 327
Remove vulnerable version of cross-fetch #404
Conversation
Error: #404, reviewer not found |
Any chance we can get this merged and get a |
@wbt, you probably should run a
https://github.com/MetaMask/web3-provider-engine/blob/main/yarn.lock#L3338 |
Backporting lquixada#124 to the 2.x branch for dependencies stuck on that which can't get a PR for moving on reviewed, e.g. MetaMask/web3-provider-engine#404
@brianlenz I've learned the hard way to exclude package-lock files from PRs to web3 projects. If a maintainer wants to do that, or if someone else wants to issue a PR against my branch awaiting a maintainer's indication that that can be merged first, fine, but I'm not going to sink my own PR by violating a rule like that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I took a look and you're right, it seems like this dependency is no longer used. Seems like someone else in #400 had the same idea too. Thanks so much and sorry for the long delay on this.
Backporting #124 to the 2.x branch for dependencies stuck on that which can't get a PR for moving on reviewed, e.g. MetaMask/web3-provider-engine#404
Backporting #124 to the 2.x branch for dependencies stuck on that which can't get a PR for moving on reviewed, e.g. MetaMask/web3-provider-engine#404
is this available in a public version? i don't see a 16.0.4 with this change a @brianlenz was asking for above |
No, there has not been a publish since the time this PR was merged. You could use a git ref if you really want to, but you'll miss future patches unless updating back after this does eventually get published. |
16.0.4 is now released with this change. Cheers! |
Closes #401.