Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

fix: hooked-wallet-ethtx tx.sign #465

Merged
merged 3 commits into from
Apr 22, 2024
Merged

fix: hooked-wallet-ethtx tx.sign #465

merged 3 commits into from
Apr 22, 2024

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented Dec 19, 2023

some bump of ethereumjs-tx broke this

@kumavis kumavis requested a review from a team as a code owner December 19, 2023 08:08
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kumavis — where did you see the bug so I can replicate it?

@legobeat
Copy link
Contributor

@mcmire I added a test case for signTransaction for hooked-wallet-eth-tx provider. It's otherwise identical to the existing one for hooked-wallet.

@legobeat legobeat merged commit 6a57b56 into main Apr 22, 2024
8 checks passed
@legobeat legobeat deleted the kumavis-patch-1 branch April 22, 2024 02:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants