Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

devDeps: ethjs@^0.3.6 -> @metamask/ethjs@^0.6.0 #470

Merged
merged 1 commit into from
Apr 17, 2024
Merged

devDeps: ethjs@^0.3.6 -> @metamask/ethjs@^0.6.0 #470

merged 1 commit into from
Apr 17, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Apr 16, 2024 •
edited
Loading

Replace legacy ethjs with @metamask/ethjs.

Blocking

@legobeat legobeat requested a review from a team as a code owner April 16, 2024 12:22
@socket-security Socket Security
Copy link

socket-security bot commented Apr 16, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/runtime@7.24.4 None 0 262 kB nicolo-ribaudo
npm/@metamask/ethjs@0.6.0 Transitive: network +13 4.31 MB lgbot
npm/@metamask/number-to-bn@1.7.1 None +2 311 kB lgbot
npm/regenerator-runtime@0.14.1 None 0 27.9 kB benjamn

🚮 Removed packages: npm/ethjs-util@0.1.3, npm/ethjs@0.3.9

View full report↗︎

@legobeat legobeat requested review from kumavis and Gudahtt April 16, 2024 12:23
@legobeat legobeat mentioned this pull request Apr 16, 2024
Merged
3 tasks
Gudahtt
Gudahtt previously approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat requested a review from Gudahtt April 16, 2024 12:58
@legobeat legobeat mentioned this pull request Apr 17, 2024
Merged
2 tasks
@legobeat legobeat merged commit 5400086 into MetaMask:main Apr 17, 2024
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kumavis kumavis kumavis approved these changes

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @kumavis @Gudahtt