Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pharo-4.0 test failing ... #323

Closed
dalehenrich opened this issue Jan 23, 2015 · 7 comments
Closed

Pharo-4.0 test failing ... #323

dalehenrich opened this issue Jan 23, 2015 · 7 comments

Comments

@dalehenrich
Copy link
Member

from test:

**************************************************************************************
    Results for #('BaselineOfMetacello') Test Suite
558 run, 557 passes, 0 skipped, 0 expected failures, 0 failures, 1 errors, 0 unexpected passes
**************************************************************************************
*** ERRORS *******************
    MetacelloGoferFunctionalTest debug: #testCommitNewPackageSpec.
**************************************************************************************
@dalehenrich
Copy link
Member Author

@demarey have there been recent changes (as of today?) to gofer for 4.0 ... The Pharo-4.0 tests passed 3 days ago and now they are consistently failing ....

@dalehenrich
Copy link
Member Author

It turns out that the test is failing because of a MNU: testCommitNewPackageSpec Error: MessageNotUnderstood: MCClassDefinition>>createClass ... is that something that has changed long term for Pharo-4.0?

@demarey
Copy link
Contributor

demarey commented Jan 23, 2015

Hi Dale,

Indeed, there was a change done yesterday. You can see the diff here: pharo-project/pharo-core@347681d. It is good to catch this problem early.
It looks like there is only one test failing: MetacelloGoferFunctionalTest debug: #testCommitNewPackageSpec. I will report this problem. Thanks

dalehenrich added a commit that referenced this issue Jan 23, 2015
…c to expected failures for Pharo-4.0 until Pharo bug is fixed
@dalehenrich
Copy link
Member Author

Thanks @demarey I've put in an expectedFailure for Pharo4.0 for that test so we can have lush green-ness ... I think that that method is only used in that particular test so if it is permanent, we can change the tests ...

@demarey
Copy link
Contributor

demarey commented Jan 27, 2015

Marcus integrated a fix for this test. Your tests should be back to green for Pharo 4.0 now.

@dalehenrich
Copy link
Member Author

Thanks @demarey! I'll remove the expected failure when I get the chance.

@dalehenrich
Copy link
Member Author

expected failures removed: 678375c

dalehenrich added a commit that referenced this issue Feb 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants