Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push cache driectory to concrete classes #345

Merged
merged 10 commits into from
Jun 22, 2015
Merged

Push cache driectory to concrete classes #345

merged 10 commits into from
Jun 22, 2015

Conversation

krono
Copy link
Collaborator

@krono krono commented May 5, 2015

  • Metacello-GitBasedRepository-topa.14
  • Metacello-Bitbucket-topa.6
  • Metacello-GitHub-topa.46

@krono
Copy link
Collaborator Author

krono commented May 12, 2015

@dalehenrich any comments?

@krono
Copy link
Collaborator Author

krono commented May 18, 2015

Test failures only due to #348

@dalehenrich
Merge pull request #338 from theseion/master
2976f4c 
More documentation for BaselineOf
@dalehenrich dalehenrich mentioned this pull request May 28, 2015
Open
@dalehenrich
Copy link
Member

I presume that this is a bugfix for Issue #347 (which actually post-dates this PR:)

@krono
Copy link
Collaborator Author

krono commented May 29, 2015

yep

@krono
Push cache driectory to concrete classes
e212617 
 - Metacello-GitBasedRepository-topa.14
 - Metacello-Bitbucket-topa.6
 - Metacello-GitHub-topa.46
@krono
Ping travis
af5829d
@krono
Merge remote-tracking branch 'krono/master'
e7d1515 
* krono/master:
  Push cache driectory to concrete classes
@krono
Copy link
Collaborator Author

krono commented Jun 21, 2015

All running except for one. What do you think?

@dalehenrich
Copy link
Member

I am rerunning the test .. it's a little disturbing that the error happens to be in bitbucket test, but I cannot guess how the changes you made would cause a test to Error out ... I love that you updated the docs!

I'lll wait fo the test to run and then merge with cautione:)

@krono
Copy link
Collaborator Author

krono commented Jun 22, 2015

Ok.

@krono
Copy link
Collaborator Author

krono commented Jun 22, 2015

Btw: The doc updates somehow slipped in here, don't ask me.
They were not in here initially. I think there's been a slip by github, but nevertheless, the docu by Max seems helpful

@dalehenrich
Copy link
Member

Hmmm, I've seen some of these commits like that show up merges in other projects ... makes you wonder a bit, but it seems to be benign ... the test is green (bitbucket network failure most likely), so we this puppy will be merged shortly ...

dalehenrich added a commit that referenced this pull request Jun 22, 2015
@dalehenrich
Merge pull request #345 from krono/master
50764ba 
Push cache driectory to concrete classes
@dalehenrich dalehenrich merged commit 50764ba into Metacello:master Jun 22, 2015
@krono
Copy link
Collaborator Author

krono commented Jun 22, 2015

\o/

@krono krono mentioned this pull request Aug 31, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krono @dalehenrich @theseion