Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore file-upload meteor-method by ostrio:files [2] #45

Merged

Conversation

SimonSimCity
Copy link
Member

Since the reference to my old repo got lost, this is the completion of #34

The package ostrio:files registers meteor-method calls starting by "_FilesCollectionWrite_" followed by the name of the file-collection. These method-calls are used to upload files to the server. Monitoring these methods (which come in rapidly as we want to upload the file fastest possible) would result in sending the full file in a EJSON encoded way also to the monitoring system.
@codecov-io
Copy link

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   99.48%   99.48%           
=======================================
  Files           6        6           
  Lines         196      196           
  Branches       49       49           
=======================================
  Hits          195      195           
  Misses          1        1
Impacted Files Coverage Δ
instrumenting/session.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97653ae...56ab7ba. Read the comment docs.

@SimonSimCity SimonSimCity merged commit c290842 into Meteor-Community-Packages:master Feb 12, 2020
@SimonSimCity SimonSimCity deleted the meteor-files branch March 31, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants